{comment}.timestamp not exists anymore and changed to {comment}.changed

Files: 
CommentFileSizeAuthor
#19 comment-1069080-19.patch1.77 KBCaligan
PASSED: [[SimpleTest]]: [MySQL] 35,840 pass(es).
[ View ]
#10 comment-1069080-10-D7.patch1.72 KBCaligan
#9 D8comment.patch644 bytesCaligan
PASSED: [[SimpleTest]]: [MySQL] 33,599 pass(es).
[ View ]
#7 D8comment.patch643 bytesCaligan
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch D8comment_0.patch.
[ View ]
#5 D8comment.patch643 bytesCaligan
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch D8comment.patch.
[ View ]
#4 comment-1069080-2-D7.patch1.14 KBCaligan
#2 comment-D7-1069080-2.patch1.14 KBCaligan
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch comment-D7-1069080-2.patch.
[ View ]
#1 comment_d8.patch644 bytesdroplet
m.patch1.16 KBdroplet
PASSED: [[SimpleTest]]: [MySQL] 31,586 pass(es).
[ View ]

Comments

Version:7.x-dev» 8.x-dev
StatusFileSize
new644 bytes

new patch for D8 and same patch of D7 above.

Status:Needs work» Reviewed & tested by the community
StatusFileSize
new1.14 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch comment-D7-1069080-2.patch.
[ View ]

D8 patch looks fine. Revised the D7 patch comment_update number.

Status:Needs review» Needs work

The last submitted patch, comment-D7-1069080-2.patch, failed testing.

StatusFileSize
new1.14 KB

One the bot should ignore....

StatusFileSize
new643 bytes
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch D8comment.patch.
[ View ]

Exact replica of #1 patch, un-suffixed to kick the testbot.

Status:Reviewed & tested by the community» Needs work

The last submitted patch, D8comment.patch, failed testing.

Status:Needs work» Reviewed & tested by the community
StatusFileSize
new643 bytes
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch D8comment_0.patch.
[ View ]

Exact was the wrong answer... updated diff to tip of latest.

Status:Reviewed & tested by the community» Needs work

The last submitted patch, D8comment.patch, failed testing.

Status:Needs work» Reviewed & tested by the community
StatusFileSize
new644 bytes
PASSED: [[SimpleTest]]: [MySQL] 33,599 pass(es).
[ View ]

Status:Reviewed & tested by the community» Needs review
StatusFileSize
new1.72 KB

Whitespace correction to D7 patch. Also defines defgroup updates-7.x-extra.

Status:Needs review» Reviewed & tested by the community

Reviewed this with Caligan in irc.

The 8.x patch looks definitely RTBC to me.

The 7.x patch I realised I'm not sure how we're supposed to do 7.x-7.x update defgroups now (6.x had nearly all updates in system.install due to disabled modules fright), and I also couldn't believe we don't have one yet. Either way that also looks good but might want to leave it CNR/RTBC for D7 for a bit after 8.x commit just to thrash this out.

Tagging issues not yet using summary template.

Issue tags:+needs backport to D7

This is needed to go on in #1164852: Inconsistencies in field language handling, see #74.

Version:8.x-dev» 7.x-dev
Issue tags:-needs backport to D7

Committed to 8.x. Moving to 7.x.

Status:Reviewed & tested by the community» Needs review

Needs D7 reviews

Status:Needs review» Reviewed & tested by the community

Looks great for D7 too.

Status:Reviewed & tested by the community» Needs work

This looks good, but now that schema descriptions actually do something (show up in PHPMyAdmin and other tools), we should make sure we cover this with an update hook in 7.x.

Sorry, catch pointed out #10 has the update hook. The docblock comments look a bit off, though:

<?php
/**
  * @} End of "defgroup updates-6.x-to-7.x"
+ */
+
+
/*
+ * @defgroup updates-7.x-extra Extra system updates for 7.x
+ * @{
+ */
+
+
/* @} End of "defgroup updates-7.x-extra"
?>

Note the first chunk starts with /** and these new chunks don't. Let's get a quick patch that fixes that up and doesn't come with the -D7.patch extension so testbot can have a crack.

Status:Needs work» Needs review
StatusFileSize
new1.77 KB
PASSED: [[SimpleTest]]: [MySQL] 35,840 pass(es).
[ View ]

Updated, docblock fixed, go-go-gadget testbot.

Status:Needs review» Reviewed & tested by the community

Status:Reviewed & tested by the community» Fixed

Rock! Thanks a bunch.

Committed and pushed to 7.x.

Status:Fixed» Closed (fixed)
Issue tags:-Quick fix, -Needs issue summary update

Automatically closed -- issue fixed for 2 weeks with no activity.