I just noticed that if the "Always use system time" global setting is unchecked, then the following warning appears when awarding points:

Notice: Undefined variable: time in _userpoints_transaction() (line 721 of /Users/benkaplan/git/drupal-7.0/sites/all/modules/userpoints/userpoints.module).

--Ben

CommentFileSizeAuthor
#1 fix_typo.patch715 bytesberdir

Comments

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new fix_typo.patch715 bytes

This should fix that.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

An general note:

I'm still uploading patches, so that they can be tested and reviewed. However, I'm also creating separate branches for each issue, named after the issue nid.

So, you can get the change with this:

git fetch
git checkout --track origin/1070126

If your git version is very recent (1.7.4+), you can write the second command list like this:

git checkout 1070126
BenK’s picture

BenK commented
Status: Needs review » Reviewed & tested by the community

The patch works great. This is RTBC.

--Ben

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

Thanks for testing, commited.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.