Closed (cannot reproduce)
Project:
Views (for Drupal 7)
Version:
7.x-3.x-dev
Component:
User interface
Priority:
Minor
Category:
Bug report
Assigned:
Reporter:
Created:
23 Feb 2011 at 14:40 UTC
Updated:
25 Mar 2011 at 17:37 UTC
Jump to comment: Most recent file
Comments
Comment #1
r.villetet commentedComment #2
merlinofchaos commentedHmm. I think we might need to call drupal_set_title() with the field that prevents check_plain().
Unless I"m misremembering, all the validators will check their titles, not just this one.
Comment #3
dawehnerThis shouldn't run check_plain again.
Comment #4
dawehnerSo does someone understand why it does not work at the moment?
Chaning this things without real knowledge of the issue might cause security issues.
Comment #5
merlinofchaos commentedI think because in Drupal 6, drupal_set_title() didn't run check_plain() so Views was coded to make sure the title was always safe.
In D7, that causes double encoding.
Comment #6
dawehnerCheck_plain isn't runned anymore, just filter_xss_admin, see the two screenshots.
Comment #7
john_t commentedI've been all over forum trying to find solution for following errors:
Declaration of views_plugin_argument_validate_taxonomy_term::init() should be compatible with that of
views_plugin_argument_validate::init() in require_once()
Declaration of views_plugin_argument_validate_taxonomy_term::options_submit() should be compatible with that of
views_plugin_argument_validate::options_submit() in require_once
I have updated to latest version of developer edition, plus ran the following patches to try and fix them including this one:
1015960-12-exposed_filters_ajax_0.patch
1022484-uc_product-views-image.patch
views-1025518.patch
And when trying to run 'this patch' (views_1070590.patch) I get the following error:
'views_plugin_argument_validate_taxonomy_term.inc' doesn't exist. (which is true because I can't find it when I searched for it in folder: C:\xampp\htdocs\drupal\sites\all\modules\views\plugins either.)
I'm new at Drupal, so I might be making some really simple mistakes that could case errors etc., so any further suggestions for me to try and remove these bugs would be appreciated.
Comment #8
merlinofchaos commentedThat's because it's in modules/taxonomy because it's a module specific plugin.
Comment #9
merlinofchaos commentedTesting the current code, I see no evidence of double encoding on taxonomy term titles when using the validator.