For both node and comments, the index paging is severely broken:

  • The page argument defaults to 1 instead of the documented 0
  • The page argument is used as the ->limit() pager instead of changing the page

As far as I know, we don't need to use the PagerDefault at all here.

CommentFileSizeAuthor
#1 1071560-indexing-paging.patch5.33 KBdamien tournoud

Comments

damien tournoud’s picture

damien tournoud commented
Status: Active » Needs review
StatusFileSize
new 1071560-indexing-paging.patch5.33 KB

Fixed the paging in node and user. Also extended the node tests.

gdd’s picture

gdd
he/him
Primary language English
Location Portland, OR
commented
Status: Needs review » Closed (fixed)

This is great, with tests and everything! Committed, thanks!