The result of having empty extensions or mimetypes expressions is not correct. The input processing does not allow the use case of only matching the listed extensions with no mimetype expression since media_admin_type_manage_form_submit() explodes these fields with a space. The end result for matching an empty field is array(0 => '').
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 1077308_media_type_settings.patch | 1.99 KB | JacobSingh |
| #3 | mediatype-input-bug-1077308-3.patch | 1.22 KB | recrit |
| #2 | mediatype-input-bug-1077308-2.patch | 1.21 KB | recrit |
| #1 | mediatype-input-bug-1077308.patch | 1.1 KB | recrit |
Comments
Comment #1
recrit commentedthe attached patch addresses the input parsing issue.
Comment #2
recrit commentedupdating patch - making both inputs split on spaces only and adding array_filter() to remove empty inputs
Comment #3
recrit commented- re-rolling as relative so that it can be applied with drush make. (@see http://drupal.org/node/1054616#comment-4152234)
- adding trimming operation to input parsing
Comment #4
eclipsegc commentedsub
Comment #5
JacobSingh commentedThis looks good, but I re-wrote it a bit in a format which doesn't use a regex or loops. I also added some docs. In general, this type definition screen is screwy. I'd like to do more to it, but this will help.
Does this also work for you?
Comment #6
recrit commentedworks for me. This looks good for a quick/hot fix for now, but I agree for having a better form for these settings.
Possibly a multi-select list of the allowed file extensions.
Comment #7
JacobSingh commentedFixed! Thanks :)
http://drupalcode.org/project/media.git/commit/c050764ead1851dffea7ceb7f...