drupal_goto doc says "either" but presents only one alternative

Hm. No idea here... someone will need to investigate. Thanks for reporting!

Temporarily setting back to 7.x so the test bot will hopefully kick off. It looks like we aren't testing d8 yet.

That aside... a few issues with this patch:
a)

+ * If a destination was specified in current request's URI, i.e.
+ * $_GET['destination'], then it will override the $path and $options values

1. in current ==> in the current
2. URI, i.e. ==> URI, i.e., (punctuate i.e. as if it was "that is", which is what it means -- must be followed by a comma)

b) The code example doesn't seem to use $destination after setting it, so I'm not getting what it does at first glance?

How's this look?

Thanks, looks good! Please commit to 7 and 8.

Needs to go to d8 and then d7

Committed to 8.x. Moving back to 7.x.

This was already committed to 8.x-dev, but it needs some work. The sample code is not valid:

$destination = array('destination' => "node/$node->nid");
l(t('Log in'), array('@login' => url('user/login', array('query' => array($destination)))));

Do you mean?

$query = array('destination' => "node/$node->nid");
l(t('Log in'), 'user/login', array('query' => $query));

Or perhaps even better

l(t('Log in'), 'user/login', array('query' => drupal_get_destination()));

good idea. Sorry for missing that in my previous review.

drupal_get_destination() has some odd behaviors that distracted from the explanation so I chose not to use it. It also obscures the data format, I suppose as my "example" demonstrates.

I agree, let's not use that function, but the example is still wrong I think?

So, shall we use:

$query = array('destination' => "node/$node->nid");
l(t('Log in'), 'user/login', array('query' => $query));

That example looks fine to me. Since we're trying to stay mostly within 80 character lines in docblocks, having it be two lines like that is probably good; if it was just code, I'd probably say to just put it all in one line.

Needs a patch...

Follow-up patch for 8.x.

OK, looks good! Let's get this into 8.x. Then we need to make a patch like #5, but with the example in #15, for 7.x. So please mark "patch / to be ported / 7.x". Thanks!

Tag.

Committed to 8.x.

Marking 7.x/to be ported.

(Btw, Jennifer, I always really appreciate those helpful instructions at the end of all your sign-offs! :))

Patch for 7.x

Looks good - let's get this into D7. Thanks!

Originally reported problem does not exist in D6, so this should be good.

Committed by Webchick:

bobvin@bowie:~/d8$ git log
commit 8a9f7b6d4a75e52327180ab3b10d2fd73471469b
Author: webchick <webchick@24967.no-reply.drupal.org>
Date:   Wed Jun 1 01:47:29 2011 -0700

    Issue #1079214 follow-up by pillarsdotnet: Adjustment to drupal_goto() doc example.