Tests are failing for Storm patches, because the testbot is trying to clone multiple versions of Storm - and hence failing the second time because the storm/ directory already exists:

Example snippet from review log:
[02:22:06] checkout_directory=sites/default/files/checkout; module_directory=sites/default/modules
[02:22:09] Command [git clone --reference /var/cache/git/reference -b '6.x-1.x' 'git://git.drupal.org/project/storm.git' 2>&1] succeeded
Duration: 3 seconds
Directory: [/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules]
Completion status: [0]
Output: [Cloning into storm...].
[02:22:09] Dependency [git://git.drupal.org/project/storm.git (6.x-1.x)] checkout into [sites/default/files/checkout/sites/default/modules] complete.
[02:22:09] Command [git clone --reference /var/cache/git/reference -b '6.x-2.x' 'git://git.drupal.org/project/storm.git' 2>&1] failed
Duration 0 seconds
Directory [/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules]
Status [128]
Output: [fatal: destination path 'storm' already exists and is not an empty directory.].
[02:22:09] Dependency [git://git.drupal.org/project/storm.git (6.x-2.x)] checkout into [sites/default/files/checkout/sites/default/modules] failed.
[02:22:09] Encountered error on [checkout], details:
array (
'@reason' => 'failed to checkout from [git://git.drupal.org/project/storm.git]',
)
[02:22:09] Review complete.

This should be cloning only the 6.x-2.x branch.

Example test - http://qa.drupal.org/pifr/test/130804, but this has happened for all Storm patches since the Git migration.

CommentFileSizeAuthor
#8 pifr.fix_storm_fail_1081082.patch3.31 KBrfay

Comments

carsten müller’s picture

carsten müller commented

subscribing

in storm no patches can be tested, please can somebody check this issue as soon as possible?

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Project: Drupal.org infrastructure » Project Issue File Review
Component: qa.drupal.org » Code

We're sprinting on PIFR tomorrow

juliangb’s picture

juliangb commented

Did the sprint get as far as this at all?

Thanks!

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

Sorry, we didn't get to this. But we will! See http://groups.drupal.org/node/132994#comment-435684

carsten müller’s picture

carsten müller commented

Hi rfay,

what about this issue?
At the moment we can't test the patches for storm and so the issues can not get fixed. I know you have a lot of work, but we can not continue with development.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

@carsten, I consider it as critical as you do. I've spent nearly every waking hour of the last 4 days getting this into shape, and it's not there yet. And I may run out of time for this "sprint". I'm sure you know that you can test locally and report the results? http://drupal.org/simpletest. It's just as valid as the testbot.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

And you'll be happy to know I think I got this one today. Not sure how soon it can be deployed though.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Active » Needs review
StatusFileSize
new pifr.fix_storm_fail_1081082.patch3.31 KB

I think this is working now. I won't mark it fixed until it's actually deployed.

Committed: http://drupalcode.org/project/project_issue_file_review.git/commit/f2df5ac

It was in fact trying to check out the code twice, because two different objects were taking responsibility for that process. This removes the one that was apparently redundant.

carsten müller’s picture

carsten müller commented

Hi rfay,

thanks for your help and your engagement. Yeah, i know that i can test locally, but my notebook is running all day for projects. And for teamwork the drupal tests are better because everybody can see the test results in detail.

I don't want to agitate anybody and i know that you have a lot to do. I just want to make sure that this issue is not lost.

Let's hope that everything works fine now. If we are going to met some day i'll spend you a beer (or maybe two or more ;-))

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

I would appreciate if any interested parties would test the current code in the staging environment.

Information about how to test is at http://groups.drupal.org/node/137189

juliangb’s picture

juliangb commented

Randy, thanks for your work on this. I've done some tests on the dev site and all seems fine and working.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Needs review » Fixed

Yay. This is deployed and looks to me like this one is good.

juliangb’s picture

juliangb commented

Thanks a lot for your help.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

And you for yours, @juliangb. It was nice that somebody took me up on that. Builds confidence when somebody else gives a go at something.

-Randy

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.