entity_metadata_view_single(), which is currently used for comments, doesn't take the necessary additional $node parameter for comment_view() into account.
The attached patch corrects this and also uses comment_view_multiple(), for possible performance improvements.

CommentFileSizeAuthor
#4 entity.comment_view.patch1.75 KBdrunken monkey
entity.comment_view.patch1.81 KBdrunken monkey

Comments

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Active » Needs review
fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Needs work

We just found another API inconsistency.. Patch looks good though.

+  $build = array();// Returned build array.
+  $nodes = array();// The nodes for all comments.
+  $nid_comments = array();// The comments, indexed by nid and then by cid.

Comments should always be on a separate line. I don't think we really need them though, maybe only the last one.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs work » Needs review

Here is an updated patch, also with/for -p0. (Or was the "needs work" for the other API inconsistency?)

Did you know, by the way, that Git has a "diff.noprefix" option starting with 1.7.2? :D

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
StatusFileSize
new entity.comment_view.patch1.75 KB
fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Fixed

thanks, committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.