Closed (won't fix)
Project:
Ubercart
Version:
7.x-3.x-dev
Component:
User Interface
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
8 Mar 2011 at 20:21 UTC
Updated:
24 May 2011 at 09:52 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
tr commentedCan you just use .uc-price:first-letter ?
Comment #2
Sergey Naumov commentedUnfortunately for some countries currency sign goes after the price and can consist of more than one letter/symbol. Even in Ubercart store settings one can decide where to display the currency sign - after the price or before.
Comment #3
tr commentedOK.
Comment #4
Sergey Naumov commentedAny update on this?
Thank you.
Comment #5
longwaveIf you can make a patch with your suggested changes, this feature is likely to get added more quickly.
Comment #6
Sergey Naumov commentedOK, this is my first patch. I hope it works :)
Comment #7
Sergey Naumov commentedComment #8
Sergey Naumov commented*bump*
Comment #9
Equ commentedsubscribing
Comment #10
Sergey Naumov commentedI'm sorry for asking, but is this so difficult to implement? Why is it taking more than two months just to add one extra
<span>? The patch is ready and working. We need this. Really.Thank you and sorry once again for complaining.
Comment #11
longwaveuc_currency_format() returns a plain string at present, not HTML, so this is technically an API change - we have to be sure that the output is never check_plain()'ed or similar anywhere before committing this. Otherwise, unexpected HTML tags may be displayed to the user.
I am not fully convinced this is useful for most users, so perhaps this would be better handled by overriding theme_uc_price() in your local theme - which raises the further point that we now have theme('uc_price') and uc_currency_format() which do very similar things.
Comment #12
Sergey Naumov commentedOverriding
theme_uc_price()in my local theme is not working for me. So I've overriden it in the module. In case if someone needs it:Comment #13
edicting commentedThe patch has improper showing on store control panel.
Pls check my upload image:
http://oi64.tinypic.com/2w5n2v4.jpg