The module administration page does not "remember" which fieldsets have been collapsed. This can be frustrating for sites with large numbers of projects and modules.

I'm about to roll a patch that stores the collapsed state of the fieldsets in a cookie and remembers them when a user loads the modules page.

CommentFileSizeAuthor
#1 remember-fieldset-states-1089302.patch1.79 KBpifantastic

Comments

pifantastic’s picture

pifantastic commented
StatusFileSize
new remember-fieldset-states-1089302.patch1.79 KB

Hooks into the collapsed event for fieldsets on the module page. Stores a cookie for the fieldset's state. Initializes the fieldsets using the cookie when the module page loads.

steven jones’s picture

steven jones commented
Version: 7.x-dev » 8.x-dev

Possibly a good idea, but new features only go into Drupal 8 at the moment, I believe.

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented
Status: Needs review » Needs work

needs a reroll against HEAD at minimum. Take a look at the js coding standards as well, I noticed they have a rule for using for..in syntax. And there's a minor spacing issue on the line + states = $.cookie('Drupal.system.modules');

nod_’s picture

nod_
Primary language French
Location Lille
commented

better check with module.hasOwnProperty(id) in the if.

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented
Status: Needs work » Needs review

#1: remember-fieldset-states-1089302.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, remember-fieldset-states-1089302.patch, failed testing.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs work » Closed (won't fix)

We discussed that in the middle of the module page redesign, basically we're just providing collapsible elements and like the rest of core, we don't remember the state of them.