Greetings,

After updating to the latest dev version of the module, notification messages are no longer displayed to users when they earn points. I have set the option to display messages in the admin settings, but this does not seem to work. I am also using the modules:

- User Points Contributed Modules
- User Points Top Contributors

I sincerely appreciate any help you can provide.

Many thanks,

Shane.

CommentFileSizeAuthor
#1 userpoints_1092562_01.patch622 bytesbdurbin

Comments

bdurbin’s picture

bdurbin commented
StatusFileSize
new userpoints_1092562_01.patch622 bytes

Confirmed in 6.x-1.x-dev and current release version. Lines 590-595 of userpoints.module ensure that if certain keys on the $params array aren't set, that they are initialized to a NULL value. $params['display'] is one of these.

Lines 686-688 use $params['display'] as a part of the logic that determines whether or not to display a message to the user. The portion of the expression that reads: !array_key_exists('display', $params) is no longer valid, since the code referenced above will ensure that that key is always set.

The attached patch resolves the issue.

bdurbin’s picture

bdurbin commented
Status: Active » Needs review

Neglected to set status to "needs review" in the previous post.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Thanks, I probably broke that when I fixed the E_NOTICE errors in the tests.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.