Rules is required for sending confirmation emails and adding conditions to shipping quotes, but it should not be necessary if the store admin needs no conditions for these.

CommentFileSizeAuthor
#5 1092738-reduce-rules-v2.patch16.44 KBAnonymous (not verified)
#2 1092738-reduce-rules.patch16.43 KBlongwave
#1 1092738-uc_cart-notify-without-rules.patch2.85 KBlongwave

Comments

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review
StatusFileSize
new 1092738-uc_cart-notify-without-rules.patch2.85 KB

Patch for basic checkout notifications without Rules.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
StatusFileSize
new 1092738-reduce-rules.patch16.43 KB

More work on this. Only uc_file, uc_role and uc_stock have Rules as a hard dependency now.

NPC’s picture

NPC commented

Can't easily apply the patch locally (it refers to Git paths), so will subscribe to this issue for now.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

You can use "patch -p1 < file.patch" (or "git apply") to easily apply Git-style patches.

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new 1092738-reduce-rules-v2.patch16.44 KB

Due to a typo (you forgot closing curly bracket) after applying patch from message #2 appears following PHP error: "PHP Parse error: syntax error, unexpected T_ELSE in /sites/all/modules/ubercart/shipping/uc_quote/uc_quote.pages.inc on line 50".

I attach corrected patch fixing this issue (it is the same patch from message #2 with line 55 inserted and line 46 corrected for patch to be applied properly).

Anonymous’s picture

Anonymous (not verified) commented
Priority: Normal » Major
Status: Needs review » Reviewed & tested by the community

I raise priority to Major and set status to RTBC because this patch seems to work fine and I really hope it will be committed before next beta.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Fixed

Thanks for the review, committed.

tr’s picture

tr commented

This line in the patch generates a syntax error because of a missing $ in front of the conditions variable:

-  if ($conditions = rules_config_load('uc_taxes_' . $rate_id)) {
+  if (module_exists('rules') && conditions = rules_config_load('uc_taxes_' . $rate_id)) {

I committed the fix.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.