It would be useful to show sizes greater than 1024 MB as Gigabytes with decimal precision.

CommentFileSizeAuthor
#17 size_in_gigs-1093740-0.patch660 bytesmitgr81
#13 size_in_gigs-1093740-0.patch660 bytesmitgr81
#12 size_in_gigs-1093740-0.patch1.03 KBmitgr81
#11 1093740-format_size_in_gigs-3-D6.patch660 bytesmitgr81
#9 1093740-format_size_in_gigs-3-D6.patch660 bytesmitgr81
#8 1093740-format_size_in_gigs-3-D6.patch660 bytesmitgr81
#4 1093740-format_size_in_gigs-3-D6.patch660 bytesmitgr81
#1 size_in_gigs-1093740-0.patch1.03 KBmitgr81

Comments

mitgr81’s picture

mitgr81 commented
StatusFileSize
new size_in_gigs-1093740-0.patch1.03 KB
mitgr81’s picture

mitgr81 commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, size_in_gigs-1093740-0.patch, failed testing.

mitgr81’s picture

mitgr81 commented
StatusFileSize
new 1093740-format_size_in_gigs-3-D6.patch660 bytes

Rebuilt patch:

mitgr81’s picture

mitgr81 commented
Status: Needs work » Needs review
mitgr81’s picture

mitgr81 commented
Status: Needs review » Active
mitgr81’s picture

mitgr81 commented
Status: Active » Needs review
mitgr81’s picture

mitgr81 commented
StatusFileSize
new 1093740-format_size_in_gigs-3-D6.patch660 bytes

Just trying to trigger build, same patch as 2nd attachment.

mitgr81’s picture

mitgr81 commented
StatusFileSize
new 1093740-format_size_in_gigs-3-D6.patch660 bytes

Yet another attempt at running this patch through the builds.

mitgr81’s picture

mitgr81 commented

#1: size_in_gigs-1093740-0.patch queued for re-testing.

mitgr81’s picture

mitgr81 commented
StatusFileSize
new 1093740-format_size_in_gigs-3-D6.patch660 bytes
mitgr81’s picture

mitgr81 commented
StatusFileSize
new size_in_gigs-1093740-0.patch1.03 KB
mitgr81’s picture

mitgr81 commented
StatusFileSize
new size_in_gigs-1093740-0.patch660 bytes

Files is hard!

Status: Needs review » Needs work

The last submitted patch, size_in_gigs-1093740-0.patch, failed testing.

mitgr81’s picture

mitgr81 commented
Status: Needs work » Needs review

#13: size_in_gigs-1093740-0.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, size_in_gigs-1093740-0.patch, failed testing.

mitgr81’s picture

mitgr81 commented
Status: Needs work » Needs review
StatusFileSize
new size_in_gigs-1093740-0.patch660 bytes

Trying again with a non-git patch

Status: Needs review » Needs work

The last submitted patch, size_in_gigs-1093740-0.patch, failed testing.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Version: 6.x-dev » 8.x-dev

Feature requests go to the latest development branch. That said, I think this is a very useful patch.

mitgr81’s picture

mitgr81 commented

I would have pushed it up to D8-dev, but I saw that there's this functionality (and beyond) in D7 (Didn't check D8, just assumed it was there).

That might explain why the tests kept failing for me, thanks for the follow-up.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Version: 8.x-dev » 6.x-dev

Oops, sorry. I should have checked before changing the version.
This is the D7 (and D8) version: http://api.drupal.org/api/drupal/includes--common.inc/function/format_size
This is in D6: http://api.drupal.org/api/drupal/includes--common.inc/function/format_si...
Only linking for now, I don't know whether we should backport the entire function from D7 or not...

Status: Needs work » Closed (outdated)

Automatically closed because Drupal 6 is no longer supported. If the issue verifiably applies to later versions, please reopen with details and update the version.