Add the ability for administrators to manually recalculate non-cart order line item prices

For anyone interested right now the work around for this is to flick every order into the Checkout: Checkout status. This causes taxes to be calculated for the order.

Hi Damien,

The issue here is that orders created through admin don't receive tax application because the calculate price routine is not fired. I can create a perfectly functional system without installing cart or checkout modules but taxes are not calculated. So when the order is viewed, there are no taxes present.

An example use case for this would be an invoicing based system.

Hmmm ok this issue is actually a bit wider than just the cart part of it.

When editing any order, taxes should be recalculated upon any changes to line items. This is not currently the case for all order statuses.

So as it stands right now it is possible to create a scenario where taxes are not calculated at all, or a scenario where taxes have been calculated, but then items on the order changed but taxes not recalculated to demonstrate.

Is it possible to just have the tax calculation routine firing on all line item changes/additions/deletions?

Have renamed this as this is more than just a tax issue.

Not sure whether this should be a separate issue, but noticed the "Unit Price" field on the admin order edit screen is an editable field for non-Price Calculation triggering order statuses, but is disabled for statuses that trigger price calculation.

Price calculating statuses: [Shopping cart: Shopping cart], [Checkout: Checkout] & [Checkout: Review]

This means that an order in [Checkout: Complete] status can have its price updated and the order not total correctly. Given that when the Calculate Sell price routine runs it overrides the price held in Unit Price regardless of whether it has been modified admin, it raises the question as to when one would actually need the field editable.

Agree having the ability to trigger manually for non cart statuses would be a good thing and would resolve issues raised here.

What needs to be called in order to recalculate the order totals?

I can manipulate prices in non-cart state orders, and the line totals update, but the order totals, taxes etc do not.

Is this as simple as making a call to a price calc routine?

From a UX perspective, wouldnt it make sense when the Unit price field is edited, and the order is a non-cart status, to apply an "edit-changed" state to the form, with the typical yellow highlighted box advising that changes will be saved and order totals will be updated once the order is saved.

This way the administrator is aware that manipulating the price will change the order total (although I struggle to picture a use case where one would want to manipulate the price of an order line item without updating the order totals).

I'm marking this a duplicate of http://drupal.org/node/1124414 as I think that issue more succinctly explains the issue of totals/taxes not being recalculated

Reopening as not fixed by the fix for http://drupal.org/node/1124414

Why can't I simply change the trigger for the rule: "Calculate taxes: Sales tax".

the "Calculating the sell price of a product" event only occurs through cart statuses, and further will reset any manual price overrides. What is preventing me from moving this routine say to the "After an Order is Saved/After an order is updated event. This would ensure that taxes were always calculated on orders, even if they did not go through the cart system.

This would certainly provide a far more flexible system - allowing administrators to place tax routines wherever was appropriate for their use case.

Ideas greatly appreciated.

Sam