D7 provides better date formatting facilities, so Ubercart should make use of them.

CommentFileSizeAuthor
d7-date-api.patch18.16 KBlongwave

Comments

tr’s picture

tr commented

Looks like a good thing to do. Patch applies and seems to work. One question - wouldn't it be better to use uc_store_date_format for the new variable name instead of date_format_uc_store ?

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

date_format_TYPE is the variable used by Drupal core, where TYPE is the key from hook_date_format_types(). The UI for setting this variable is at /admin/config/regional/date-time.

tr’s picture

tr commented
Status: Needs review » Reviewed & tested by the community

OK.

tr’s picture

tr commented

While you're at it - does this address #632882: Time format is hard coded in order comments ?

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Needs work

No, it doesn't change that format. Perhaps we should use "short" date format for the comments and inject a line break?

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Fixed

Committed anyway, let's fix the time format in that separate issue.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.