Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
documentation
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
18 Mar 2011 at 14:30 UTC
Updated:
29 Jul 2014 at 19:27 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
jhodgdonBy convention, it should begin with a cap letter and end with a period. The sentence could be reworded to make it clear that's a convention.
Comment #2
davidtrainer commentedHow's this?
Comment #3
drewish commentedThe patch looks like it's editing watchdog() not drupal_set_message(). That said I didn't try applying it.
The new comment sounds kind of awkward. How about something like "The message to be displayed to the visitor. For consistency with other messages you should begin with a capital letter and end with period."
Comment #4
gbrands commentedI like the proposed description by drewish; however, 'visitor' should be changed to 'user' as drupal_set_message applies to more than just a site's visitors (e.g., admins, editors, other roles, etc...)
Comment #5
davidtrainer commentedgbrands, I agree. Patch attached.
drewish, the patch definitely changes the comment block above drupal_set_message(). I'm guessing git shows watchdog() there because it is the last function declaration previous to the changed lines. I rolled the patch with plain old git diff.
Comment #6
jhodgdonLooks good to me! Let's get this into d8 and d7.
Comment #7
dries commentedCommitted to 8.x. Moving to 7.x. Thanks for the clarification.
Comment #8
davidtrainer commentedOops, missed a grammatical error. Sorry about that.
Comment #9
jhodgdonWhoops, I missed that too, thanks! Please commit to d8 and then we need to combine the two patches for d7.
Comment #10
dries commentedCommitted to 7.x and 8.x.