user-menu and main-menu have the menu suffix while management and navigation do not

Seems to make more sense drop the suffix since we already know they are menus.

CommentFileSizeAuthor
#4 1098054-drop-menu-suffix.patch19.3 KBboombatower
#1 1098054-drop-menu-suffix.patch20.76 KBboombatower

Comments

boombatower’s picture

boombatower commented
Assigned: Unassigned » boombatower
Status: Active » Needs review
StatusFileSize
new 1098054-drop-menu-suffix.patch20.76 KB
boombatower’s picture

boombatower commented

missed by bot

Status: Needs review » Needs work

The last submitted patch, 1098054-drop-menu-suffix.patch, failed testing.

boombatower’s picture

boombatower commented
Status: Needs work » Needs review
StatusFileSize
new 1098054-drop-menu-suffix.patch19.3 KB

Rebased.

Status: Needs review » Needs work

The last submitted patch, 1098054-drop-menu-suffix.patch, failed testing.

bfroehle’s picture

bfroehle commented

Whoa, neat failures in #4, namely now multiple elements are ending up having the same id:

The HTML ID main is unique. Other ajax.test 385 AJAXMultiFormTestCase->testMultiForm()
Initial page contains unique IDs Other ajax.test 385 AJAXMultiFormTestCase->testMultiForm()

Maybe we need to be making the HTML id be MENUNAME-menu ?

boombatower’s picture

boombatower commented

Probably a good idea.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

dawehner’s picture

dawehner
Primary language German
commented
Issue summary: View changes
Status: Needs work » Fixed

We actually resolved that in Drupal 8: (account, admin, footer, main)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.