I'd like to see us implement some easy condition for checking the components of addresses on orders... it should involve selecting the order, selecting the type of address, and selecting the component of the address, the comparison operator, and a value to compare against. This will allow users to configure tax rules without having to do some crazy entity has field checks and long chains in data selectors to drill down to the billing country. Functionally this will be equivalent to what we're doing for pricing rules (i.e. adding actions for line items to manipulate the unit price), just at the condition level.
Comments
Comment #1
tgeller CreditAttribution: tgeller commentedSubscribing.
Comment #2
rszrama CreditAttribution: rszrama commentedAlrighty, committed this. However, I'm experiencing other difficulties now trying to determine the appropriate order to check against and potentially hitting the code I put in place to prevent the double application of any particular pricing rule. I'm going to open a secondary issue for the order determination, as what really needs to happen is the Cart module should be able to say when a product price is being calculated that the pseudo-line item belongs to a particular order.
Comment #3
tgeller CreditAttribution: tgeller commentedAwesome, just checked it out. Thanks!
What should the data selector be?
Comment #4
rszrama CreditAttribution: rszrama commentedFor now use line-item:order, though I have an open issue for that that I turned up during development here.