Closed (fixed)
Project:
Views Slideshow
Version:
7.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
23 Mar 2011 at 04:39 UTC
Updated:
17 Jan 2017 at 21:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
snufkin commentedI dont really know how the screenreader would affect the slider, never worked with any, so Im afraid i cant really assist with that.
Comment #2
mgiffordNo worries. You don't need to be an expert in accessibility and we can help test & evaluate this.
Looking at the code the problem seems to be that you have links that aren't links:
There is no way for someone to get to this without a mouse. The behavior isn't quite right either.
Likewise with image navigation:
There should be links around the image.
Comment #3
snufkin commentedHmm this seems to be a views slideshow issue, not really slider related, so moving the issue there.
Comment #4
mgiffordThanks for moving it to the right issue queue.
Comment #5
mgiffordJust adding an anchor tag helps make it accessible to keyboard only users. I haven't tested this solution with screen readers yet, but it is a step ahead:
views-slideshow-controls-text-next.tpl.php
views-slideshow-controls-text-pause.tpl.php
views-slideshow-controls-text-previous.tpl.php
EDIT: A similar change should be made to views-slideshow-pager-field-field.tpl.php, however I can't get the
<a href="#">close enough to the image to allow this to be linkable. I think it's probably in views_slideshow.theme.inc but I can't find it yet.Comment #6
redndahead commentedThanks. I didn't quite think about screen readers when I made that change. Doh! Thanks for the heads up and a very legitimate reason for using links.
Comment #7
mgiffordCool. Great to hear. I'm not quite sure about how to do this for pages like http://openconcept.ca/portfolio which use the images to make the transition.
Comment #8
redndahead commentedI could easily wrap the thumbnails in a tags. What's the best way to describe what the a tag does? title?
Comment #9
mgiffordI'm quite certain it would need to be a link if it is going to work for keyboards & screen readers. It's about navigation as much or more than it is displaying data.
A link (even to #) around an image should be sufficient. What output were you thinking?
Comment #10
redndahead commentedThis patch just got committed. Sorry for the long delay.
Comment #11
mgiffordThanks!
Comment #13
mgiffordThis must have been reverted at some point. It's back to using div's.
EDIT: Actually, I think it's just that only addresses some of the navigational elements and there are a few others that are defaulting still to div's.
Comment #14
dshields commentedHere is a patch that addresses this issue for using fields as the pager items.
Comment #18
nickdickinsonwildehmm the problem I can see with that is that your pager items could be a link in which case that'd be wrong. Thinking about best way to work around that and get this in to 7.x-3.3.
Comment #19
nickdickinsonwildeOkay, that should do it nicely! Thanks for the input waay back there.