Sometime during the Views sprint a few weeks ago we fixed some issues where Views wasn't showing its main breadcrumbs properly.

However, there are a couple less-visited places where the breadcrumbs still don't work correctly. On the clone/analyze/export/delete pages of a view, the breadcrumb says "Home".

This patch fixes that. Mostly it's just a straightforward change of menu callbacks to MENU_VISIBLE_IN_BREADCRUMB. I also had to move the title callback function to views_ui.module, though, so it's always actually loaded when it's needed for the breadcrumb (without that, Drupal unhelpfully just puts an empty entry inside the breadcrumb rather than failing with some kind of actual error, which made it a pain to track this issue down - see #1059884: Drop function_exists for 'callback' functions for the core issue that would fix that).

CommentFileSizeAuthor
#2 views-edit-breadcrumbs.png28.4 KBDavid_Rothstein
views-fix-breadcrumbs.patch3.35 KBDavid_Rothstein

Comments

merlinofchaos’s picture

merlinofchaos commented

I'm not sure this is enough. The 'edit' page is also not showing a proper breadcrumb at this time, and I fiddled with it for awhile and couldn't figure out how to fix it.

David_Rothstein’s picture

David_Rothstein commented
StatusFileSize
new views-edit-breadcrumbs.png28.4 KB

For me the breadcrumbs on the edit page say "Home » Administration » Structure » Views" (see attached screenshot), which I think is correct. Do you see something different?

One thing I noticed while working on this was that it was possible to code yourself into a situation where even a cache clear did not make the menus match what was in the code. I actually had to uninstall and reinstall. So if you see something different than the above and haven't uninstalled in a while, maybe trying uninstalling Views+Ctools and starting again. It is kind of disturbing that can happen, though.

David_Rothstein’s picture

David_Rothstein commented

Though of course, uninstalling and reinstalling is not an option for someone with a real site upgrading from Drupal 6 :) I haven't checked at all what happens to the breadcrumbs in that case.

bojanz’s picture

bojanz commented

Yeah, I only see "Home » Administration » Structure" in the breadcrumb when editing a View. The install is less than a month old (3 weeks, I think), will try to reinstall...

merlinofchaos’s picture

merlinofchaos commented

I see the same as bojanz. This is a pretty old install, though.

I have seen places where hook_menu refuses to make changes to existing items. :/

dawehner’s picture

dawehner
Primary language German
commented

Here is a installation which was created after the codesprint and here the breadcrumb works fine.

bojanz’s picture

bojanz commented
Status: Needs review » Reviewed & tested by the community

Reinstalled, and the main breadcrumb is now good.
And David's patch fixes the other breadcrumbs. Yay!

merlinofchaos’s picture

merlinofchaos commented
Status: Reviewed & tested by the community » Fixed

Committed, pushed out.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.