This is a patch to improve documentation summaries in the node module to better conform to Doxygen and comment formatting conventions and improve consistency.

I focused on creating/improving the one-line summaries; particularly useful in IRC w/Druplicon. Obviously more extensive documentation is warranted in places, but I'd ask to keep this issue focused on summaries.

Particularly in need of review are these previously undocumented functions:

/**
 * Helper function for node_admin_content()'s delete operation.
 *
 * @see node_admin_content()
 */
function node_multiple_delete_confirm($form, &$form_state, $nodes) {

/**
 * Submit handler for the multiple node delete confirmation form.
 *
 * @see node_multiple_delete_confirm()
 */
function node_multiple_delete_confirm_submit($form, &$form_state) {

/**
 * Checks if the current user may do the given operation on the given revision.
 */
function _node_revision_access($node, $op = 'view') {

/*
 * Checks if the current user may add nodes.
 */
function _node_add_access() {

/**
 * Returns when the given node last changed.
 */
function node_last_changed($nid) {

/**
 * Menu callback; presents the add page form.
 */
function node_add_page() {

/**
 * Submit handler for the 'Preview' button on the node form.
 */
function node_form_build_preview($form, &$form_state) {

/**
 * Submit handler for the 'Revert' button on the node revert form.
 */
function node_revision_revert_confirm_submit($form, &$form_state) {

/**
 * Asks for confirmation of the revision deletion.
 */
function node_revision_delete_confirm($form, $form_state, $node_revision) {

/**
 * Submit handler for the 'Delete' button on the delete revision form.
 */
function node_revision_delete_confirm_submit($form, &$form_state) {

Comments

claar’s picture

StatusFileSize
new18.41 KB

Testbot ignoring my patch.. re-uploading.

(Edit: Ends up tests aren't running because of HEAD being broken -- #1097100: Remove all 7xxx update functions and tests (D6 to D7 upgrade path))

marvil07’s picture

Status: Needs review » Needs work

Great to have see new descriptions for functions, sadly this patch no longer applies(apart from core directory change).

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

arunkumark’s picture

Patch no longer applies cleanly.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

quietone’s picture

Status: Needs work » Closed (duplicate)
Related issues: +#1313980: Clean up API docs for node module

@claar, thank you for the report and the patch.

The node module docs were improved in #1313980: Clean up API docs for node module closing this as a duplicate.