In the module uninstall form the module name is not clickable to select for uninstall. Contrary: in the module installation form with clicking on a module name the user can select/unselect the module to install. A small change in modules/system/system.admin.inc could solve this problem

-      '<strong>'. drupal_render($form['modules'][$module]['name']) .'</strong>',
+      '<strong><label for="' . $form['uninstall'][$module]['#id'] . '">' . drupal_render($form['modules'][$module]['name']) . '</label></strong>',
CommentFileSizeAuthor
#9 the-module-name-on-uninstall-form-is-not-clickable-1107802-6.patch774 bytespkiraly
#6 the-module-name-on-uninstall-form-is-not-clickable-1107802-5.patch768 bytespkiraly
#1 the-module-name-on-uninstall-form-is-not-clickable-1107802.patch778 bytespkiraly
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pkiraly’s picture

pkiraly CreditAttribution: pkiraly commented
FileSize
the-module-name-on-uninstall-form-is-not-clickable-1107802.patch778 bytes

Here I attached the patch file.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

Applicable to Drupal 8 and 7? In that case this should escalate from 8 and 7 to 6.

pkiraly’s picture

pkiraly CreditAttribution: pkiraly commented

I have checked Drupal 8 and Drupal 7. This is solved in both versions, with exactly the same line of code.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Category: feature » task
Status: Active » Needs review

Ok, any others to provide feedback?

Status: Needs review » Needs work

The last submitted patch, the-module-name-on-uninstall-form-is-not-clickable-1107802.patch, failed testing.

pkiraly’s picture

pkiraly CreditAttribution: pkiraly commented
FileSize
the-module-name-on-uninstall-form-is-not-clickable-1107802-5.patch768 bytes

The test result said, that "Detect a non-applicable patch.". I am not fully understand why. Anyway: I recreated the patch based upon a newly cloned 6.20 Drupal. (The code change is the same as that of the previous patch.)

pkiraly’s picture

pkiraly CreditAttribution: pkiraly commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, the-module-name-on-uninstall-form-is-not-clickable-1107802-5.patch, failed testing.

pkiraly’s picture

pkiraly CreditAttribution: pkiraly commented
Status: Needs work » Needs review
FileSize
the-module-name-on-uninstall-form-is-not-clickable-1107802-6.patch774 bytes

I found a problem in the patch (unclosed label tag), so here is another version.

Status: Needs review » Needs work

The last submitted patch, the-module-name-on-uninstall-form-is-not-clickable-1107802-6.patch, failed testing.

pkiraly’s picture

pkiraly CreditAttribution: pkiraly commented

I found, that the tests failed because of a drupal.org issue. I filed it as "The automated QA tests of D6 patch failed because it tries to apply for a different Drupal version (D8 instead of D6)" at http://drupal.org/node/1170708

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave commented
Version: 6.20 » 6.x-dev
Status: Needs work » Reviewed & tested by the community

The filename should end in -D6.patch, and there are no tests for D6 core anyway.

Having said that this looks good to me, this feature is already present in D7, and improves UX in D6 without breaking anything.

TR’s picture

TR CreditAttribution: TR commented

#9: the-module-name-on-uninstall-form-is-not-clickable-1107802-6.patch queued for re-testing.

The testbot doesn't work on fixed-point releases like 6.20. Now that @longwave has changed the issue version to 6.x-dev, the testbot should be able to apply the patch.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, the-module-name-on-uninstall-form-is-not-clickable-1107802-6.patch, failed testing.

TR’s picture

TR CreditAttribution: TR commented
Status: Needs work » Needs review

9: the-module-name-on-uninstall-form-is-not-clickable-1107802-6.patch queued for re-testing.

TR’s picture

TR CreditAttribution: TR commented

This has been RTBC for 2+ years (#12). Identical fix was already implemented long ago in D8 and D7.

I re-tested to show that the patch tests green, but the patch was marked "Passed" and the test details showed all green for the test initiated on 3 June 2011 even before the retest.

(It looks like the drupal.org upgrade to D7 may have improperly set the issue back to "Needs work". See the revision history for this issue. This is a known bug in the upgrade process.)

I suggest either:
1) commit the patch
2) mark it as won't fix

TR’s picture

TR CreditAttribution: TR commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

RTBC by issue #12 and others.

TR’s picture

TR CreditAttribution: TR commented

9: the-module-name-on-uninstall-form-is-not-clickable-1107802-6.patch queued for re-testing.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 9: the-module-name-on-uninstall-form-is-not-clickable-1107802-6.patch, failed testing.

Status: Needs work » Closed (outdated)

Automatically closed because Drupal 6 is no longer supported. If the issue verifiably applies to later versions, please reopen with details and update the version.