Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Work around is of course to set the "Method for viewing passwords" to "Own page" instead of "Both" or "Collapsible box". But I would consider this an unexpected behaviour though, and we all sometimes do a login as admin with somebody in the back – maybe on a machine where JS is disabled and experiencing this behaviour the first time.
Would be a small change to make the fieldset invisible with a "display: none;" and finally reveal it by JS itself on page load.
Comment | File | Size | Author |
---|---|---|---|
#8 | password_is-1114780-8.patch | 3.14 KB | iberezovchuk |
Comments
Comment #1
Leeteq CreditAttribution: Leeteq commentedI think that when Javascript is disabled, it should provide a dedicated link to load the password manually to its own "page".
With JS enabled, the link should collapse so the password is initially hidden behind the link, then revealed inline when clicking on the link.
(Setting it for 7.x first, which then may be backported.)
Comment #2
EvanDonovan CreditAttribution: EvanDonovan commentedPersonally, I think this might be considered a security issue. Not everyone uses JS.
It is mitigated to a certain extent by the fact that only the user will see it him/herself.
What's the best way to handle this, do you think?
Comment #3
iberezovchuk CreditAttribution: iberezovchuk commentedThere are ajax link for showing password on user page.
Comment #4
andriyun CreditAttribution: andriyun commentedI think code from this function should move to line 416.
There is no need for new custom function.
Please note to space after dots. And line length should be less than 80 characters
Please add documentation for function.
Comment #5
andriyun CreditAttribution: andriyun commentedIf aes_view_password_form is never used, should be remove function code from module
Comment #6
podarokUser's pasword
Needs docblock
Needs docblock
Comment #7
iberezovchuk CreditAttribution: iberezovchuk commentedComment #8
iberezovchuk CreditAttribution: iberezovchuk commentedThere is patch with fixed bugs.
Comment #9
podarokCode looks good for me.
Comment #11
dpovshed CreditAttribution: dpovshed commented