All available product images (instead of only the first one) are shown in rows listing products at cart page (relative URL is /cart) and at "Home » Administration » Store » Products » View products" administration page (relative URL is /admin/store/products/view). I don't think this is intended behavior, so I consider this a bug. This bug is caused by use of field_view_field() instead of field_view_value() in uc_product_get_picture().

I attach working patch fixing this issue.

CommentFileSizeAuthor
uc_product_get_picture_multiple_images_fix.patch629 bytesAnonymous (not verified)

Comments

tr’s picture

tr commented

Yes, this is also a problem on the catalog pages. Your patch seems to fix the cart and the view products pages. Can you look at the catalog pages too and include that in this patch?

And as long as you're debugging images, can you take a look at #1022484: "Missing handler" error in default product view and see if you can solve that? That's the only other outstanding image issue I know about in 7.x-3.x. (Well, there's one other that I really should open an issue for, but let's not get into that now...).

Status: Needs review » Needs work

The last submitted patch, uc_product_get_picture_multiple_images_fix.patch, failed testing.

tr’s picture

tr commented

(Ignore the testbot results for this patch - the testbot still doesn't work correctly on fixed-point releases like 7.x-3.0-beta2)

Anonymous’s picture

Anonymous (not verified) commented

Unfortunately I do not use uc_catalog Ubercart module (I use custom-made catalog). I also neither use nor know Views module. So I can't help with catalog pages or anything View-related, terribly sorry.

Anonymous’s picture

Anonymous (not verified) commented

Unfortunately my patch failed testing because testing bot uses "patch -p0", while my patch is prepared for use with "patch -p1". Is it issue with testing bot or I should modify my patch to work with "patch -p0"? I ask because my other patches for Drupal, while prepared for use with "patch -p1", successfully pass testing.

Anonymous’s picture

Anonymous (not verified) commented

Oops, I missed your statement "Ignore the testbot results for this patch". Sorry for confusion.

tr’s picture

tr commented
Status: Needs work » Fixed

OK, I thought I would ask :-)

I committed your initial patch. Thanks. Don't hesitate to report any more bugs you find.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.