Further reduce Rules dependency in uc_flatrate Ubercart module [#1119824]

uc_flatrate Ubercart module unconditionally uses entity_flush_caches() from Entity API while Rules usage is optional.

I attach working patch fixing this issue.

Comment	File	Size	Author
	further_reduce_rules_dependency_in_uc_flatrate_fix.patch	609 bytes	Anonymous (not verified)

Comments

Comment #1

tr commented 7 April 2011 at 17:10

Category:	bug	» feature
Status:	Needs review	» Postponed (maintainer needs more info)

uc_flatrate depends on uc_quote which depends on Rules. So Rules should always be installed when uc_flatrate is enabled. I don't see the point in trying to eliminate this dependency.

Comment #2

Anonymous (not verified) commented 7 April 2011 at 18:03

As per #1092738: Make Rules less of a dependency Rules really could be optional dependency (I tested mentioned patch and it works just fine). Not everyone needs sophisticated Rules - e.g. I only need a customer to pick from a number of fixed flat rate shipping options and Rules is something I absolutely don't need! Furthermore Rules is still in early beta and it will take quite a while for it to become of release quality, while Drupal 7 and Ubercart 3 web-shops need to operate in a secure and safe manner now (Ubercart 3 beta2 with patches I provided recently is quite usable for me now). Hope you understand my point and will both consider this patch and #1092738: Make Rules less of a dependency. Thanks in advance!