The URL for one of David Strauss' attributions is "hhttp://drupal.org/user/93254".

This is real low hanging fruit so I'm grabbing it. Patch coming right up.

CommentFileSizeAuthor
#6 1120698-david-strauss-is-special.patch793 bytesdave reid
#1 Fix-URL-for-David-Strauss-d.o-profile-1120698-1.patch775 bytesskwashd

Comments

skwashd’s picture

skwashd commented
Status: Active » Needs review
StatusFileSize
new Fix-URL-for-David-Strauss-d.o-profile-1120698-1.patch775 bytes

The attached patch fixes the problem.

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented
Status: Needs review » Reviewed & tested by the community
david strauss’s picture

david strauss
he/him
commented

I've tested this patch and found that the single byte saved substantially improves the scalability of downloading MAINTAINERS.txt with high levels of concurrency. I approve.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

LOL. :)

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

LOL indeed and I was tempted to bump this to major. Otherwise we would need to add 'hhttp' to the list of allowed proctols for drupal_strip_dangerous_protocols().

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
StatusFileSize
new 1120698-david-strauss-is-special.patch793 bytes

Alternative patch.

skwashd’s picture

skwashd commented

@davereid#6 the list of allowed protocols are alphabetical. hhttp comes before http. Rereoll required.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

It's a special case so it's ok.

skwashd’s picture

skwashd commented

#1: Fix-URL-for-David-Strauss-d.o-profile-1120698-1.patch queued for re-testing.

dries’s picture

dries commented

Committed to 7.x and 8.x.

Also, nice try, Dave. ;-)

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Drat. Next time Dries...next time...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.