Jslideto module intended to override the default browsers behaviour when directed to a URL with '#' character, this module make it
easer to get the user intention when clicking on a link within the same page. in this module jquery is used to highlight the anchored elements.

http://drupal.org/sandbox/artofeclipse/1115358

Comments

artofeclipse’s picture

artofeclipse commented
Status: Active » Needs review
lslinnet’s picture

lslinnet commented

Hey,

you should take a look at the Drupal coding standards, which specifies how your code you be formattet (http://drupal.org/coding-standards)

  • Tabs used instead of spaces.
  • missing space when concatenating strings.
  • LICENSE.txt should not be included - it will be added automatically by the packaging script.

Are you sure that http://www.mlambir.com.ar/ are okay with you copying his code into this project? i don't see any copyright information in his code or on his pages concerning this javascript code.

I'm not sure if jquery.fade.js is compatible with Drupal's rules about including third party code into a project.

lslinnet’s picture

lslinnet commented
Status: Needs review » Needs work

forgot to change status

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Component: new project application » module
Status: Needs work » Closed (won't fix)

Closing, feel free to re-open if this was a mistake.