In sites/default/files/language I noticed several files names like this da_efa00db1f52a7215a581763e8951a773_1.js, i.e. with an _XX suffix. This indicates a race condition in the file generation code.

This patch adds FILE_EXISTS_REPLACE to _locale_rebuild_js() like it is used in drupal_build_js_cache() and drupal_build_css_cache().

CommentFileSizeAuthor
#30 1123154-30.patch1.18 KB_utsavsharma
#29 1123154-29.patch627 bytes_utsavsharma
#14 locale_rebuild_js-1123154-11.patch646 bytesmgifford
#13 locale_rebuild_js-1123154-11.patch646 bytesadci_contributor
#10 local_rebuild_js-5.patch626 bytesPolonium
#6 locale_rebuild_js-4.patch648 bytesc960657
#5 locale_rebuild_js-3.patch610 bytesc960657
#4 locale_rebuild_js-1-D6.patch534 bytesc960657
#2 locale_rebuild_js-2.patch572 bytesc960657
locale_rebuild_js-1.patch585 bytesc960657

Comments

Status: Needs review » Needs work

The last submitted patch, locale_rebuild_js-1.patch, failed testing.

c960657’s picture

c960657 commented
StatusFileSize
new locale_rebuild_js-2.patch572 bytes
c960657’s picture

c960657 commented
Status: Needs work » Needs review
c960657’s picture

c960657 commented
StatusFileSize
new locale_rebuild_js-1-D6.patch534 bytes

D6 backport.

c960657’s picture

c960657 commented
StatusFileSize
new locale_rebuild_js-3.patch610 bytes

Reroll.

c960657’s picture

c960657 commented
StatusFileSize
new locale_rebuild_js-4.patch648 bytes

Reroll.

c960657’s picture

c960657 commented
Assigned: Unassigned » c960657
Issue tags: +Quick fix

alansaviolobo queued 6: locale_rebuild_js-4.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 6: locale_rebuild_js-4.patch, failed testing.

Polonium’s picture

Polonium commented
Issue summary: View changes
StatusFileSize
new local_rebuild_js-5.patch626 bytes

Here is a new patch.

adci_contributor’s picture

adci_contributor commented
Status: Needs work » Needs review

I guess there is the wrong path.
go Testbot

Status: Needs review » Needs work

The last submitted patch, 10: local_rebuild_js-5.patch, failed testing.

adci_contributor’s picture

adci_contributor commented
Status: Needs work » Needs review
StatusFileSize
new locale_rebuild_js-1123154-11.patch646 bytes

I'm just fixed path of reroll in #10

Use FILE_EXISTS_RENAME when saving translation js files

This patch adds FILE_EXISTS_REPLACE to _locale_rebuild_js()

Em. Which the constant should we use?

mgifford’s picture

mgifford
he/him
Primary language English
commented
StatusFileSize
new locale_rebuild_js-1123154-11.patch646 bytes

Re-uploading the patch for the bots.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: +Needs tests

This will need to be updated for D10.1 as that function has changed.

Also if this is a bug it will need a test.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

If there's a race condition, should we be wrapping this in a lock like we do with image style generation?

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Title: Use FILE_EXISTS_RENAME when saving translation js files » Use FileSystemInterface::EXISTS_RENAME when saving translation js files

Updating title since FILE_EXISTS_RENAME was removed in D10 in favour of FileSystemInterface::EXISTS_RENAME. See https://www.drupal.org/node/3006851

_utsavsharma’s picture

_utsavsharma commented
StatusFileSize
new 1123154-29.patch627 bytes

Re-rolled #14 to 10.1

_utsavsharma’s picture

_utsavsharma commented
StatusFileSize
new 1123154-30.patch1.18 KB

Fixed CCF of #29.

smustgrave’s picture

smustgrave commented

@_utsavsharma please upload an interdiff with your patches. The sizes between #29 and #30 make me think a lot has changed.

Also still needs tests

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.