I think we should have the CAS first login redirection work on the first login for that user, period.

Currently it only works for the first login of auto-registered users. We should be able to identify first time visitors of admin-created accounts by looking at $account->login.

CommentFileSizeAuthor
#5 1127472-Have-CAS-first-login-redirection-work-.patch1.75 KBbfroehle
#3 1127472-Have-CAS-first-login-redirection-work.patch1.75 KBbfroehle
#2 1127472-Have-CAS-first-login-redirection-work-.patch1.75 KBbfroehle

Comments

metzlerd’s picture

metzlerd commented
Category: task » feature

Defined as users who have never logged in to the drupal site before, yes? That seems like a sane request as it is consistent with how drupal works at first login. I'm in favor.

bfroehle’s picture

bfroehle commented
Title: Have CAS first login redirection work, even for admin created accounts » Have CAS first login redirection work for admin created accounts
Version: master » 6.x-3.x-dev
StatusFileSize
new 1127472-Have-CAS-first-login-redirection-work-.patch1.75 KB

Patch, including a test to verify behavior.

bfroehle’s picture

bfroehle commented
StatusFileSize
new 1127472-Have-CAS-first-login-redirection-work.patch1.75 KB

Renaming the file so the test bot works.

bfroehle’s picture

bfroehle commented
Status: Active » Needs review

Oops, it's not working because I didn't set the status to Needs Review. Doh!

bfroehle’s picture

bfroehle commented
Version: 6.x-3.x-dev » 7.x-1.x-dev
StatusFileSize
new 1127472-Have-CAS-first-login-redirection-work-.patch1.75 KB

Committed to 6.x-3.x. Now on to 7.x-1.x.

bfroehle’s picture

bfroehle commented
Status: Needs review » Fixed

Tests pass, committed to 7.x-1.x. Marking as fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 7531155 on 7.x-1.x, 8.x-1.x by bfroehle: 
    Issue #1127472: Have CAS first login redirection work for admin created...