How found the bug:
1. Install a new Drupal 7.0,
2. Install Examples module (http://drupal.org/project/examples)
3. Turn on Ajax example
4. Go examples/ajax_example/ajax_link - Ajax Link ("use-ajax" class)
5. Click "Click here" link

You will got an error message like this on FireFox: "Blah...blah..blahh.. $.fieldValue is not a function"

First look the bug is in ajax_example/ajax_example_misc.inc ajax_example_render_link() function (line 20) because before add drupal.ajax library do not add jquery.form.

I think the bug isn't here. If drupal.ajax depend on jquery.form we can define it in the drupal.ajax library definition in modules/system/system.module.

CommentFileSizeAuthor
#5 1129244-ajax_depend_form.patch923 bytespp
#1 1129244-ajax_depend_form-D8.patch923 bytespp
#1 1129244-ajax_depend_form-D7.patch923 bytespp

Comments

pp’s picture

pp commented
StatusFileSize
new 1129244-ajax_depend_form-D7.patch923 bytes
new 1129244-ajax_depend_form-D8.patch923 bytes

here is the patches

pp’s picture

pp commented
Status: Active » Needs review

I test it with a following steps:
1. Install drupal 7 minimal insall
2. Turn on Field UI
3. Add a new content type
4. Add a new field which is multiple
5. Create content
6. Try "Add another item" button

pp

damien tournoud’s picture

damien tournoud commented
Status: Needs review » Needs work 
     'dependencies' => array(
-      array('system', 'drupal.progress'),
+      array('system', 'jquery.form', 'drupal.progress'),
     ),

That's most likely wrong. You need to split this in two lines.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

subscribe.

Please don't name patches that you want to be tested with -D8 or -D7. That's an odd naming convention that *prevents* testing. As you see they were ignored by the testbot.

pp’s picture

pp commented
Status: Needs work » Needs review
StatusFileSize
new 1129244-ajax_depend_form.patch923 bytes

rfay: Thanks.

Damien Tournoud:
Why? Please help me! I don't understand you. I read the coding standards, and tested the code with Coder module.

pp

pp’s picture

pp commented
Status: Needs review » Needs work

[16:34] tanarurkerem: array('system', 'jquery.form', 'drupal.progress') is not a supported syntax, as far as I know
[16:35] tanarurkerem: the third parameter is probably just ignored
[16:35] tanarurkerem: so you are in effect probably removing the dependency on drupal.progress

pp’s picture

pp commented
Status: Needs work » Closed (won't fix)

oops the bug is in only 7.0. In the 8.x and 7.x the bug isn't present.. sorry.