On certain server setups, when installing or updating a module the Update Manager code will force the associated batch to be processed immediately from within a form submit handler. This means that any submit handlers that run afterwards will never run, since processing a batch calls drupal_goto().

The standard way to handle this situation is to let the form API initiate the batch process for you, since it automatically makes sure to process the batch only after all submit handlers have run. There's never really a good reason to call batch_process() yourself from within a form submit handler.

The attached patch makes the Update Manager use that method.

CommentFileSizeAuthor
#23 interdiff_22-23.txt6.58 KBpooja saraah
#23 1130146-23.patch4.19 KBpooja saraah
#22 drupal-update_manager_batch_set-1130146-22.patch8.99 KBAnkit.Gupta
#5 drupal-update_manager_batch_set-1130146-5.patch5.75 KBmbrett5062
update-manager-batch-set.patch6 KBDavid_Rothstein

Comments

bfroehle’s picture

bfroehle commented
Issue tags: +Needs backport to D7

Tagging for possible backport to D7.

mbrett5062’s picture

mbrett5062 commented

David, do we still want this in for 8.x, if so I can re-roll and move it forward. Just assign to me if you would like me to proceed.

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented
Status: Needs review » Needs work

I say go for it!

mbrett5062’s picture

mbrett5062 commented
Assigned: Unassigned » mbrett5062

Re-rolling against latest 8.x, patch to follow.

mbrett5062’s picture

mbrett5062 commented
Status: Needs work » Needs review
StatusFileSize
new drupal-update_manager_batch_set-1130146-5.patch5.75 KB

Here is the patch for latest 8.x.

mbrett5062’s picture

mbrett5062 commented
Assigned: mbrett5062 » Unassigned
Issue summary: View changes

No longer able to work on this. And is probably redundant by now. Unassigned myself so someone else can take a look.

artem.ua’s picture

artem.ua commented

5: drupal-update_manager_batch_set-1130146-5.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 5: drupal-update_manager_batch_set-1130146-5.patch, failed testing.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented
Status: Needs work » Postponed (maintainer needs more info)
Issue tags: +Bug Smash Initiative

Thank you for reporting this problem.

There has been no activity here for 9 years.

Is this still a problem?

Since we need more information to move forward with this issue, I am setting the status to Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

dww’s picture

dww
we/he/they
commented
Status: Postponed (maintainer needs more info) » Active
Issue tags: +Needs reroll, +Needs tests

Sad to say, but yes, it's still a problem. Drupal\update\Form\UpdateReady::submitForm() is still directly invoking update_authorize_run_update() in some cases, which in turn calls system_authorized_batch_process() which eventually calls batch_process() which is the undesirable behavior explained in the summary.

Not sure if "needs work" or "active" is more accurate at this point, since so much of the code has been refactored since #5. Also, looking at that patch, it's changing many things we don't need to change, and not changing what's being requested. So yeah, this is basically back to the drawing board at this point...

Ankit.Gupta’s picture

Ankit.Gupta commented
Status: Active » Needs review
Issue tags: -Needs reroll
StatusFileSize
new drupal-update_manager_batch_set-1130146-22.patch8.99 KB

Reroll the patch #5 with Drupal 9.4.x

pooja saraah’s picture

pooja saraah commented
StatusFileSize
new 1130146-23.patch4.19 KB
new interdiff_22-23.txt6.58 KB

Fixed failed commands on #22
Attached patch against Drupal 9.4.x

Status: Needs review » Needs work

The last submitted patch, 23: 1130146-23.patch, failed testing. View results

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

dww’s picture

dww
we/he/they
commented
Status: Needs work » Closed (won't fix)

Now that #3491731: [META] Remove the ability to update modules and themes via authorize.php and child issues are done, this code is all deprecated and will be removed in D12.