Error message EntityMetadataWrapperException: Unable to load the commerce_product with the id 5053. in EntityDrupalWrapper->valu

Hmm, so the feeds deletion process somehow bypasses hook_commerce_product_delete()? I would've expected commerce_product_reference_commerce_product_delete() to deal with this.

The problem is that if you have a line item referencing a product that doesn't exists anymore, you get this error, actually you're screwed because you can't access the order UI view to delete the order b/c you get the same error there.

Steps to reproduce this:

1- Import products using commerce feeds module.
2- Create a product display referencing one of the products imported.
3- Add one product to the cart. (As an alternative you could directly create an order in cart status from order UI)
4- Delete the products via Feeds interface.
5- Visit the cart.

hook_commerce_product_delete() is called and the products are correctly removed from its displays, also commerce feeds implements this same hook to handle feeds_items table that controls the records imported.

This is something that doesn't happen in commerce by itself because you can't delete a product that is referenced by a line item. (Maybe in VBO integration?)

I think that the delete items issued from feeds normally is used for wipe out a migration and start over. I'd say that we could implement in commerce feeds, in hook_commerce_product_delete() a call to delete all line items referenced by this products. Other option would be to do something similar as the hook_commerce_product_can_delete and actually don't delete feeds items referenced in line items (not sure if feeds allows to do this check though)

Well, the thing is, the function I linked above appears to be able to unset a product reference on any entity when a product is deleted (including line items). That's why I thought it should work fine. Perhaps the $product variable Feeds is sending through the hook isn't what we expected or something?

function commerce_product_reference_commerce_product_delete($product) {
  // Check the data in every product reference field.
  foreach (commerce_info_fields('commerce_product_reference') as $field_name => $field) {
    // Query for any entity referencing the deleted product in this field.
    $query = new EntityFieldQuery();
    $query->fieldCondition($field_name, 'product_id', $product->product_id, '=');
    $result = $query->execute();

    // If results were returned...
    if (!empty($result)) {
      // Loop over results for each type of entity returned.
      foreach ($result as $entity_type => $data) {
        // Load the entities of the current type.
        $entities = entity_load($entity_type, array_keys($data));

        // Loop over each entity and remove the reference to the deleted product.
        foreach ($entities as $entity_id => $entity) {
          $entity = commerce_entity_reference_delete($entity_type, $entity, $field_name, $product->product_id);

          // Store the changes to the entity.
          entity_save($entity_type, $entity);
        }
      }
    }
  }
}

Ok, I got more information on this, probably this issue is affecting VBO integration as well...

It seems that when Feeds delete one single item, "everything works fine", meaning that if the product is in the cart or part of a line item, commerce_product_reference_commerce_product_can_delete fires and stops the deleting process, but when it has to deal with several entities to delete, those hooks hook_commerce_product_delete and hook_commerce_product_can_delete are not actually being called and this drives into the ugly error that rfay reports.

I'll look further into this in the following days

Was there any progress made on this?

I was doing some testing and created a test product type, 2 test products & test product display referencing them, then went through the order process for this product.

Now went to delete the type, got the 'exists in order X' message, so went to delete the order, but got the above error.

Can I delete the order, type & display somehow, or am I as pcambra put it, actually screwed?

I tried removing the line item through order screen but got similar:

EntityMetadataWrapperException: Unable to load the commerce_line_item with the id 1. in EntityListWrapper->value() (line 910 of /home/site/public_html/sites/all/modules/entity/includes/entity.wrapper.inc).

I think the error in #7 sounds like #1186130: Line item deletion causes EntityMetadataWrapperException. I haven't tried this, but I've been through the code fairly carefully, and I think you could successfully delete a line item (for the purpose of restoring, not as a fix) by calling commerce_line_item_commerce_line_item_delete() before commerce_line_item_delete(). (The former will end up getting called twice, but there shouldn't be anything for it to do the second time).

Hmm, I didn't mean to suggest it was a duplicate. I think the bug described in #7 is the same as #1186130: Line item deletion causes EntityMetadataWrapperException, but I'm less convinced that it's the same as this issue.

#1186130: Line item deletion causes EntityMetadataWrapperException will give an exception any time a line item is deleted, simply because we attempt to load the already-deleted line item in trying to delete a reference to it.

The issue here (i.e. in #4) seems to be that the function that deletes the references is not even being called, which strikes me as something a bit different.

On further thought, I have no idea what's going on in Tigeda's #5 and #7. If products referenced by line items have already been deleted (as indicated in #5), I would expect that one would not be able to get to the order edit form to remove the line items and get the error in #7.

@rfay What tables / fields etc. would I have to look for and delete?

@#12 Sorry I didn't mention the products had been deleted, unable to delete because they exist in the order, thats what I tried first, then wen't to delete the order and got the error.

Deleting this product cannot be undone.

This product is referenced by a line item on Order 1 and therefore cannot be deleted. Disable it instead.

My follow-up question to this issue is do we really just need to file bug reports with modules that aren't properly invoking deletion hooks when deleting entities? Perhaps we can get bojanz to confirm whether or not VBO works the same way now that he's maintaining it.

Thanks rfay, that did the trick.

For anyone else with the same situation, just add your table prefix to each line aswell, if you have one.

Ray,

Thank you! I was just about to surrender. First I had this error:

EntityMetadataWrapperException: Unable to get the data property product_id as the parent data structure is not set. in EntityStructureWrapper->getPropertyValue() (line 421 of .../sites/all/modules/entity/includes/entity.wrapper.inc).

I managed to get rid of that error only to end up by following advice here: http://drupal.org/node/1185988.

Then I was left with the following error:

EntityMetadataWrapperException: Unable to load the commerce_line_item with the id 2. in EntityDrupalWrapper->value() (line 683 of...sites/all/modules/entity/includes/entity.wrapper.inc).

#15 did the trick for me. Thanks so much!

Subscribe.

subscribe

Randy,

The "truncate" query you have listed above just saved me some time. I'm using Commerce Feeds and kept getting the "EntityMetadataWrapperException" error when I tried to create a new content type (and not even a commerce-related one!). I was also getting the same error when I tried to edit my existing product display type.

Once I ran the truncate queries, all was fine.

I think there is something else going on here, but thanks for the quick fix regardless.

Thanks,
-mike

Like dbkern I got the error:
EntityMetadataWrapperException: Unable to get the data property product_id as the parent data structure is not set. in EntityStructureWrapper->getPropertyValue() (line 421 of .../sites/all/modules/entity/includes/entity.wrapper.inc).

This appeared when I tried to edit a Vocabulary, or create a content type.

Truncating the tables in #15 cleared the error on a development site.

I just wanted to note that you'll have to truncate the tables for any fields you've added to orders:

truncate field_data_custom_order_field1
truncate field_data_custom_order_field2
truncate field_revision_custom_order_field1
truncate field_revision_custom_order_field2

dangit, didn't mean to change the bug title. just the comment subject...

well, I thought I was out of the water, but after 5 transactions i started having issues again with negative payment amounts being transfered. I fixed this by truncating my payment tables:

truncate commerce_payment_transaction;
truncate commerce_payment_transaction_revision;

This issue seems to have petered out, likely thanks to the Entity API being updated months ago to no longer throw exceptions when an out of date reference was found. We can keep an eye on this, but it seems fago fixed this upstream.

Two related issues that remain open will in fact deal with improved API access control over delete functions:

• #1243476: Move hook_commerce_*_delete() implementations into entity controllers
• #1210976: Product deletion access callback should let us know a product cannot be deleted
  

Thanks rfay for it #15 . It solved my problem.