Allow drupal_get_filename() to work with the installed profile.

Wondering if this also fixes #1149580: Prevent url() from expanding aliases while the installer is running.

It's very sad that we have so much special casing of profiles all over the place, when turning them into modules was supposed to remove that, but the patch looks good.

However it also looks like this could be added as a test very quickly too.

Should have one fail.

Should pass.

Looks ready to fly for me.

1. file_exists(DRUPAL_ROOT . '/' . $file)
The code above returns TRUE even if $file = FALSE. I think we should fix it.
2. In drupal 6 this path also doesn't come from db. Do we need backport to D6?
3. After applying the previous patch drupal_get_filename works only for current installed profile because other profiles aren't present in the system table.

Title edited by mistake.

@chi, if you look at the schema for the system table, 'filename' is set to be the primary key and cannot be NULL. So I think the extra check to see if $file is empty is not needed. Marking this as RTBC again.

Patch #4 works well for me.

EDIT: Ignore this (How did that extra stuff get into the patch???)

Re-uploading the correct patch, for clarification.

• drupal_get_filename-installed_profile-testonly-1136820-12.patch

  Test-only patch from #3.

• drupal_get_filename-installed_profile-test+fix-1136820-12.patch

  Test+fix patch from #4.

@girishmuraly
I think it isn't clean code.
Example for drupal_get_filename('module', 'nonexist');

$file = db_query("SELECT filename FROM {system} WHERE name = :name AND type = :type", array(':name' => $name, ':type' => $type))->fetchField(); // $file = FALSE because «nonexist» doesn't exist in system table.
  if (file_exists(DRUPAL_ROOT . '/' . $file)) {  // But this will be evaluated to TRUE because path «DRUPAL_ROOT . '/'» exists.
    $files[$type][$name] = $file;
  }

@Chi, actually I have to agree with you on that. Didn't think about that case. Yeah, checking: if ($file && file_exists(DRUPAL_ROOT . '/' . $file)) makes sense. A new test case needs also to be added.

Work on the D7 version of this bug is in a different bug - http://drupal.org/node/1006714. That looks more comprehensive and tests are better. Suggest we use that for D7 atleast. Removing the 'needs backport' tag here, if that makes sense.

I'm closing this as duplicate of #1006714: drupal_get_path doesn't work for profiles.

See also #1311774: Prevent path functions from using database tables that have not yet been created.