"Enable Display field" on File fields works incorrectly [#1140262]

I added a field of type File to a content type to which I allowed multiple values and the Enable Display field property. When I upload files to this field and check various files to display, the results differ (seemingly randomly but for a pattern always identically) from what I set with the checkboxes. Most notably it seems to be impossible to hide all files while checking all boxes seem to result in properly listing all of them.

I produced this with a Drupal installation having Views, Panels, CTools and Token external modules installed, I thought these won't affect this. If necessary I can experiment some more with it.

Comment	File	Size	Author
#5	1140262-filefield-display.patch	732 bytes	andypost
#3	1140262-filefield-display.patch	853 bytes	andypost

Comments

Comment #1

Bob K commented 1 May 2011 at 20:33

Function file_field_prepare_view() in file.field.inc scans an array of files available for display and deletes the unwanted items from that array. The statement at line 207 is meant to leave the array in a tidy set of consecutive ([0],[1],[2]...) elements, but that should wait until after the foreach($items...) loop is finished.

Here's how it should look:

function file_field_prepare_view($entity_type, $entities, $field, $instances, $langcode, &$items) {
  // Remove files specified to not be displayed.
  foreach ($entities as $id => $entity) {
    foreach ($items[$id] as $delta => $item) {
      if (!file_field_displayed($item, $field)) {
        unset($items[$id][$delta]);
      }
    }
    // Ensure consecutive deltas.
    $items[$id] = array_values($items[$id]);
  }
}