Correct use of drupal_static in profile2_load_by_user() [#1141552]

Comment	File	Size	Author
#1	1141552-correct-use-drupal_static-D7.patch	583 bytes	ericbroder
	profile2_static_cache.patch	575 bytes	jide

Comment #1

ericbroder commented 6 May 2011 at 18:04

Status:

Needs review

» Needs work

Status	File	Size
new	1141552-correct-use-drupal_static-D7.patch	583 bytes

Seems correct that there should be an ampersand in front of drupal_static: http://api.drupal.org/api/drupal/includes--bootstrap.inc/function/drupal...

Original patch doesn't apply for me though:

diff --git profile2.module profile2.module
index 06e7f98..8a8bfce 100644
--- profile2.module
+++ profile2.module

fatal: git diff header lacks filename information when removing 1 leading pathname components (line 5)

Attaching a new patch that hopefully is formatted better.

Log in or register to post comments

Comment #2

ericbroder commented 6 May 2011 at 18:05

Status:

Needs work

» Needs review

Log in or register to post comments

Comment #3

jide commented 10 May 2011 at 18:05

Hmmm weird that the patch did not apply for you, I used branches to create it. What command did you use to apply the patch ?

Log in or register to post comments

Comment #4

ericbroder commented 10 May 2011 at 19:29

I pretty much tried to follow the instructions here: http://drupal.org/project/profile2/git-instructions

So ultimately the command I used was:
git apply -v [patchname.patch]

If you compare our two patches, you can see the only difference is "profile2.module" in yours versus "a/profile2.module" or "b/profile2.module" in mine.

Not sure why this is significant. I'm still learning git ;-)

Log in or register to post comments

I use the branch methodology I describe here http://www.jide.fr/english/creating-git-patches because it works with drush make (and I find it a more natural workflow). This is discussed in http://drupal.org/node/1054616. Still learning GIT too though ;)