Since Rules 2 has a dependency on Entity, that module really needs to be installed and enabled before any of the database update functions for Rules run. However, they will still be attempted by update.php even if Rules has been disabled.

I believe just throwing an exception if Entity is not enabled will prevent the schema version for Rules from being updated, allowing those functions to be run in the future. It shouldn't completely halt the rest of the update for all of the other modules that have things to do at that time.

CommentFileSizeAuthor
#1 1144570_update_exception.patch813 bytesIsland Usurper

Comments

Island Usurper’s picture

Component: Rules Core » Rules Engine
Status: Active » Needs review
StatusFileSize
new813 bytes

And now with patch.

fago’s picture

Status: Needs review » Postponed

Indeed, this is a entity api problem though. See #1122812: remove entity_exportable_schema_fields() from hook_schema() implementations.

Let's implemented the fix from over there, once done.

fago’s picture

Status: Postponed » Fixed

ok, I've implemented the fix from over there, thus included the table definitions directly and avoided any calls to the entity API during install/upgrade/uninstall.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.