Hi Nancy,

Hope you don't mind me jumping in with both feet to this module but we run realname on a plethora of the NBC Universal websites (www.syfy.co.uk, www.universalchannel.co.uk, and 33 others) and are doing some database query analysis. I noticed that the module is writing the user's realname to the database every time realname_make_name gets as far as checking the {realname} table regardless of whether it needs to or not.

On our busiest sites, this is causing an extra 100 or so database UPDATEs to be run per page load, so I've had a go at creating a small patch which only runs the update if the realname has changed.

I've attached a patch below. I've not done a lot of patch creation before, and none with Git yet, so apologies if something gets mangled in the process, but I hope this will prove useful.

Best wishes,

Alex Harries

Comments

hefox’s picture

alexgreyhead’s picture

Surely that issue is a duplicate of mine, since I got there first...? ;o) Just kidding of course. I guess this can be safely closed now?

hefox’s picture

Status: Needs review » Closed (duplicate)

I think you missed that the other issue is from 2010 instead of 2011 :P

Anyhow marking as duplicate then cause sounds like there's no objections.