Closed (won't fix)
Project:
Ubercart
Version:
6.x-2.x-dev
Component:
Orders
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
5 May 2011 at 14:30 UTC
Updated:
1 Jul 2011 at 12:39 UTC
Jump to comment: Most recent file
Comments
Comment #1
elioshOps. Here is the file.
Comment #3
longwaveCan you give some examples where this is actually a performance problem?
Also, there needs to be some way of resetting the static cache; what if an order is loaded, updated, saved, and reloaded within the same page request?
Comment #4
tr commentedPatch should be made relative to the ubercart directory rather than the uc_order directory, and should be rolled against the -dev release if possible. Changing version.
Comment #5
eliosh@longwave: i reduced query from >500 to ~250 (i don't have real number now) for admin order page.
@TR: patched against -dev version with suggestions from you and from @longwave for static resetting.
Comment #6
longwaveUnsure whether this will affect existing contrib modules that may update an order somehow then expect uc_order_load() to load the updated object later in the same page request, without knowledge of the static cache.
If you can identify where on the admin page order objects are being loaded twice, perhaps that would be a better fix? Presumably you mean /admin/store/orders?
Comment #7
elioshYes, it's on "admin/store/orders/" page.
I'll try to investigate it deeper and try to understand who loads this order multiple times...
Comment #8
longwaveI still don't see how we can do this without affecting contrib through possible stale caches, and I can't see this as a real performance issue either. Please reopen with more info if this is still needed.