Patch attached that simply adds parent::options_form($form, $form_state); to the top of options_form()

This allows views to add all of the other field options into the form. like showing a label, rewriting, wrapping, etc.

CommentFileSizeAuthor
#9 privatemsg-views-link-form-1155718-9.patch580 bytesjojonaloha
privatemsg-views-link-form.patch572 bytesjon pugh

Comments

Status: Needs review » Needs work

The last submitted patch, privatemsg-views-link-form.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

And do these options actually work? I think I left them out because most made no sense or don't work with the current implementation (which is crap and needs to be fixed, but that's another story)

AntiNSA’s picture

AntiNSA commented
Priority: Normal » Critical

this does not work for me :(....

AntiNSA’s picture

AntiNSA commented
Priority: Critical » Normal

Actually it does work. Thanks

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Please provide more information.

What have you tested that works, did you find an issues with some options, ...

Tafa’s picture

Tafa commented

works for me

designcontext’s picture

designcontext commented

Works for me!
I need to rewrite the field with something.

mjgruta’s picture

mjgruta commented

This patch is usefull if you want to use "Exclude from display" on your [privatemsg_link] so you can load it on your custom text.

jojonaloha’s picture

jojonaloha commented
Version: 7.x-1.1 » 7.x-1.x-dev
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new privatemsg-views-link-form-1155718-9.patch580 bytes

The original patch works for me as well. I was using it to add additional classes in the "Style settings" options.

I've re-rolled the patch for 7.x-1.x-dev, it looks like the original wasn't applying which is why it failed testing.

ptmkenny’s picture

ptmkenny commented
Related issues: +#1573000: Preliminary Views integration
ndobromirov’s picture

ndobromirov commented
Status: Needs review » Reviewed & tested by the community

Hi, this patch worked for me too, marking it as RTBC.

ndobromirov’s picture

ndobromirov commented
Issue tags: +views integration

Hi, I've been using the patch from #9 in production for 2 months now without any problems.
RTBC still stands.

ivnish’s picture

ivnish
he/him
commented
Status: Reviewed & tested by the community » Closed (outdated)