Webform 7.x-3.9
Eloqua Integration 7.x-1.0
I am trying to enable the eloqua integration for my webform but it does not save the configuration.
In edit mode of the webform in the Eloqua Integration Options I am checking the Enabled box and entering my form name and submit.
I get these errors and if I return to the edit mode the options are not saved.
Notice: Trying to get property of non-object in eloqua_form_webform_node_form_alter() (line 187 of /sites/all/modules/contrib/eloqua/eloqua.module).
Notice: Trying to get property of non-object in eloqua_form_webform_node_form_alter() (line 193 of /sites/all/modules/contrib/eloqua/eloqua.module).
Notice: Trying to get property of non-object in eloqua_form_webform_node_form_alter() (line 199 of /sites/all/modules/contrib/eloqua/eloqua.module).
Notice: Trying to get property of non-object in eloqua_form_webform_node_form_alter() (line 199 of /sites/all/modules/contrib/eloqua/eloqua.module).
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | eloqua_options_not_saving-1155850-d6-08.patch | 1.1 KB | drupalninja99 |
| #7 | eloqua_options_not_saving-1155850-07.patch | 2.21 KB | drupalninja99 |
| #6 | eloqua_options_not_saving-1155850-06.patch | 2.52 KB | drupalninja99 |
| #6 | interdiff.txt | 1.12 KB | drupalninja99 |
| #4 | interdiff.txt | 1.5 KB | drupalninja99 |
Comments
Comment #1
CKoch commentedHere's a patch that will solve those issues with a change the webform module.
Also, you should apply the patch at: http://drupal.org/node/1088074 to fix a cron issue.
Comment #2
anthonylbest commentedI am struggling to figure out how to apply this patch would it be possible for you to simply upload a new version of this module with the patch applied?
Thanks.
Comment #3
ultimike@CKoch - I think you missed a single character in your patch that causes the PHP notices ("Trying to get property of non-object in eloqua_form_webform_node_form_alter()") to still appear.
In the function signature for your _eloqua_form_webform_node_form_alter_default_settings() function, you forgot to pass the $settings variable in by reference.
Instead of:
function _eloqua_form_webform_node_form_alter_default_settings($settings) {it should be
function _eloqua_form_webform_node_form_alter_default_settings(&$settings) {I've updated your patch and attached it below.
Thanks,
-mike
Comment #4
drupalninja99 commentedThis looks good, I just don't think we need an extra function call so I moved the new code into the form alter.
Comment #5
drupalninja99 commentedI think this is ready to go, we just need a 6x port.
Comment #6
drupalninja99 commentedForgot to remove the function, re-rolling.
Comment #7
drupalninja99 commentedForgot to merge in my change from 7.x-1.x.
Comment #8
drupalninja99 commentedAttaching D6 patch
Comment #9
drupalninja99 commentedPushed to 6.x-1.x and 7.x-1.x
Comment #10
drupalninja99 commented