Patch makes sure the file element has #access = TRUE before setting form to accept files.

I have stumbled across this issue when using user-modal (currently in my sandbox) which adds the login/ register forms inside CTools modal.

The user_register_form() has:

  $form['picture'] = array(
    '#type' => 'fieldset',
    '#title' => t('Picture'),
    '#weight' => 1,
    '#access' => (!$register && variable_get('user_pictures', 0)),
  );

Without this patch, this will result with $form_state['has_file_element'] = TRUE;

CommentFileSizeAuthor
#21 file-element-visible-1158928-21.patch971 bytesludo.r
#11 7.44-file-element-visible-1158928-11.patch2.53 KBIRuslan
#9 file-element-visible-1158928-9.patch819 bytesIRuslan
#1 1158928-file-element-visible-1.patch2.8 KBamitaibu
file-element-visible.patch655 bytesamitaibu

Comments

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
StatusFileSize
new 1158928-file-element-visible-1.patch2.8 KB

This patch doesn't prevent from every file to work ;)

It's checks for explicitly setting the #access to FALSE. Patch comes with tests.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented

#1: 1158928-file-element-visible-1.patch queued for re-testing.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented

#1: 1158928-file-element-visible-1.patch queued for re-testing.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented

#1: 1158928-file-element-visible-1.patch queued for re-testing.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented

Patch still applies, lets see if bot still likes it.

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented

#1: 1158928-file-element-visible-1.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1158928-file-element-visible-1.patch, failed testing.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

IRuslan’s picture

IRuslan commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new file-element-visible-1158928-9.patch819 bytes

From what I see this patch is for Drupal 7. And it works for me. +1 RTBC.

Also, I've attached simple adaptation for D8.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented

Wow, that's an old one ;)

IRuslan’s picture

IRuslan commented
StatusFileSize
new 7.44-file-element-visible-1158928-11.patch2.53 KB

Just for who is concerned by this error in D7, I've adopted patch for the last core version (7.44).

Status: Needs review » Needs work

The last submitted patch, 11: 7.44-file-element-visible-1158928-11.patch, failed testing.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

ludo.r’s picture

ludo.r
Location Brussels
commented
Version: 9.2.x-dev » 9.3.x-dev
Status: Needs work » Needs review
Issue tags: +Bug Smash Initiative
StatusFileSize
new file-element-visible-1158928-21.patch971 bytes

Re-rolled the patch against 9.3.x

I aslo included a check for disabled elements.

quietone’s picture

quietone commented
Status: Needs review » Needs work
Issue tags: +Needs issue summary update

Came be to review but there isn't enough information in the Issue Summary and the code that is there is for Drupal 7

It would help if this used that standard issue template with the steps to reproduce, remaining tasks and proposed resolution complete.

Thanks

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Version: 9.5.x-dev » 11.x-dev
Status: Needs work » Postponed (maintainer needs more info)

We really need some steps to reproduce this if we are going to keep this open. Is this still relevant? If so, when?

quietone’s picture

quietone commented
Status: Postponed (maintainer needs more info) » Closed (outdated)

There have been two attempts here to get more information to know if this is still a problem or to provide steps to reproduce. None has been provided.

Therefore, closing as outdated. If this is incorrect reopen the issue, by setting the status to 'Active', and add a comment explaining what still needs to be done.

Thanks!