I've had me head in Panels for the last few months so I decided to take on UR's panels integration.

The attached is only a very rough start, there may be the need for a larger rewrite to make this work correctly with Panels 3.

Files: 
CommentFileSizeAuthor
#18 user_relationships_panels_visibility-d7-port-1159638-18.patch3.48 KBhedley
PASSED: [[SimpleTest]]: [MySQL] 995 pass(es).
[ View ]
#15 user_relationships_panels_visibility-d7-port-1159638-15.patch1.31 KBhedley
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch user_relationships_panels_visibility-d7-port-1159638-15.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#12 user_relationships_panels_visibility-d7-port-1159638-12.patch2.69 KBmrf
PASSED: [[SimpleTest]]: [MySQL] 995 pass(es).
[ View ]
#10 user_relationships_panels_visibility-d7-port-1159638-10.patch3.58 KBmrf
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch user_relationships_panels_visibility-d7-port-1159638-10.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#8 user_relationships_panels_visibility-1159638-8.patch1.19 KBhedley
PASSED: [[SimpleTest]]: [MySQL] 995 pass(es).
[ View ]
#5 ur-panels-visibility.patch9.21 KBmrf
FAILED: [[SimpleTest]]: [MySQL] Failed to run tests: No such module [user_relationships_panels_visibility].
[ View ]
panels-visibility-port.patch9.35 KBmrf
FAILED: [[SimpleTest]]: [MySQL] Failed to run tests: No such module [user_relationships_panels_visibility].
[ View ]

Comments

Title:Update Panels Integration for7.x-1.xUpdate Panels Integration for 7.x-1.x
Status:Active» Needs review

Status:Needs review» Needs work

The last submitted patch, panels-visibility-port.patch, failed testing.

No idea what's wrong with the testbot...

--- /dev/null
+++ b/user_relationship_panels/plugins/access/ur_relationship.incundefined

Thinking about the name. I think we should start to standardize on user_relationship*s* as the module prefix, because that's the project name is and what the base module is called. And while most are the other way round right now, I think we shold name new modules correctly.

+++ b/user_relationship_panels/user_relationship_panels.infoundefined
@@ -0,0 +1,8 @@
+files[] = plugins/ur_relationship.inc

Does panels.module actually use this? Because files[] usually only has an effect if classes are inside that file and should only be used then.

Powered by Dreditor.

Subbing

Status:Needs work» Needs review
StatusFileSize
new9.21 KB
FAILED: [[SimpleTest]]: [MySQL] Failed to run tests: No such module [user_relationships_panels_visibility].
[ View ]

Updated the naming conventions for the panels submodule, and moved the implementation a little further along.

Visibility option is now loading as expected, but it still doesn't look like everything is working correctly.

Status:Needs review» Needs work

The last submitted patch, ur-panels-visibility.patch, failed testing.

subscribe...

Status:Needs work» Needs review
StatusFileSize
new1.19 KB
PASSED: [[SimpleTest]]: [MySQL] 995 pass(es).
[ View ]

Couple of small changes, the 'core' was set to 6.x and the $form wasn't being returned in the settings form.

This sub-module seems to work for me with those edits now.

Why not use and test mrf's patch from #5?

StatusFileSize
new3.58 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch user_relationships_panels_visibility-d7-port-1159638-10.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

The rename made this way to hard to evaluate, will do that as a separate step. I think this is almost there but I know there were bugs when I last looked at this.

Status:Needs review» Needs work

The last submitted patch, user_relationships_panels_visibility-d7-port-1159638-10.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new2.69 KB
PASSED: [[SimpleTest]]: [MySQL] 995 pass(es).
[ View ]

Left in some of the remaining noise from the rename.

The missing $form return was keeping everything from working. As far as I can tell its working the same as d6 but would love some testing of this patch.

Thanks, was just figuring out what was going on with the other patches.

@Berdir - didn't realise those patches hadn't made it into dev

Will test this now

Forgot to mention that I posted #1469496: Rename user_relationships_panels_visibility to cover the renaming aspect.

StatusFileSize
new1.31 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch user_relationships_panels_visibility-d7-port-1159638-15.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Tested #12 and it is working well for me, using with the user profile page template.

One thing which I need is for the logged in user to be able to see the same thing when viewing their own profile as a user with a relationship can see. I've attached a patch which provides and option to do this, dependent on the patch in #12.

Status:Needs review» Needs work

The last submitted patch, user_relationships_panels_visibility-d7-port-1159638-15.patch, failed testing.

@hedley

Patches always need to contain all changes, partial patches are not supported by the testbot.

Please provide a combined patch and I'll commit this asap. I'm not currently using this submodule but we can deal with additional stuff later on once the initial port is commited.

Status:Needs work» Needs review
StatusFileSize
new3.48 KB
PASSED: [[SimpleTest]]: [MySQL] 995 pass(es).
[ View ]

Ok, still learning :) - here's a patch which combines #12 & #15

Status:Needs review» Fixed

Ok, commited and pushed. Thanks for working on this.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.