I am breaking my core queue boycott to get that fucking patch in. Using this issue to avoid having to spam that one with debug patches.

CommentFileSizeAuthor
#13 just_tests.patch2.74 KBcatch
#12 stop_bleeding_please_0.patch2.23 KBcatch
#10 stop_bleeding_please_0.patch2.38 KBcatch
#9 no_test_hunk.patch2.37 KBcatch
#7 all_types_again.patch5.55 KBcatch
#5 all_types_again.patch5.55 KBcatch
#3 all_types.patch5.44 KBcatch
#1 stop_bleeding_please.patch4.97 KBcatch

Comments

catch’s picture

catch
he/him
Primary language English
commented
StatusFileSize
new stop_bleeding_please.patch4.97 KB

Starting from http://drupal.org/node/1017672#comment-4468134

Status: Needs review » Needs work

The last submitted patch, stop_bleeding_please.patch, failed testing.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new all_types.patch5.44 KB

Status: Needs review » Needs work

The last submitted patch, all_types.patch, failed testing.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new all_types_again.patch5.55 KB

Status: Needs review » Needs work

The last submitted patch, all_types_again.patch, failed testing.

catch’s picture

catch
he/him
Primary language English
commented
StatusFileSize
new all_types_again.patch5.55 KB

Makes a change I suppose.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Needs review
catch’s picture

catch
he/him
Primary language English
commented
StatusFileSize
new no_test_hunk.patch2.37 KB

Let's try without the test hunk at all.

catch’s picture

catch
he/him
Primary language English
commented
StatusFileSize
new stop_bleeding_please_0.patch2.38 KB

Original patch without the test hunk.

Status: Needs review » Needs work

The last submitted patch, stop_bleeding_please_0.patch, failed testing.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new stop_bleeding_please_0.patch2.23 KB

eh?

catch’s picture

catch
he/him
Primary language English
commented
StatusFileSize
new just_tests.patch2.74 KB

And the other half of the patch.

Status: Needs review » Needs work

The last submitted patch, just_tests.patch, failed testing.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs work » Closed (duplicate)

#1160928: Add tests for node type/comment body upgrade path