uc_taxes should add included taxes to the subtotal line item. [#1160088]

The subtotal line item should display the total of the prices listed in the cart. Currently, if these prices are being displayed with tax included, the subtotal line item is the sum of the untaxed prices. Thus the subtotal line item and the subtotal in the cart pane are different, which is confusing. And uc_taxes already provides its own "Subtotal excluding taxes" line item.

The attached patch implements hook_uc_line_item_alter() to accomplish this.

Comment	File	Size	Author
	uc_taxes-subtotal-alter.patch	1.63 KB	wodenx

Comments

Comment #1

wodenx commented 17 May 2011 at 12:40

Status:

Active

» Needs review

Comment #2

wodenx commented 23 May 2011 at 23:17

Status:

Needs review

» Needs work

I just realized that the prices listed in the cart contents checkout pane are also displayed without taxes, regardless of the $display_include setting. So, really, the patch should be extended to modify that display as well - I'll try to do that when I have a chance.

Comment #3

wodenx commented 14 June 2011 at 20:45

This is essentially the same as #1153086: Inclusive tax not visible in cart block or checkout pane. I have reworked my patch and will post it there. This should probably be marked as a duplicate.