When I click the "Clear all caches" button on the Performance page, I get two warnings:

Notice: Undefined index: join field in flag_views_data_alter() (line 174 of .../sites/all/modules/flag/includes/flag.views.inc).
Notice: Undefined index: join field in flag_views_data_alter() (line 189 of .../sites/all/modules/flag/includes/flag.views.inc).

I'm using 7.x-2.0-beta5, without any patches. This happens every time I clear all caches.

CommentFileSizeAuthor
#6 undefined_index-1160738-6.patch2.48 KBgeerlingguy
#2 flag_undefined_index-1160738-2.diff585 bytesgeerlingguy

Comments

geerlingguy’s picture

geerlingguy commented

Both of those lines read like the following:

  'relationship field' => $info['join field'],

I seem to also be getting this error after saving a view.

geerlingguy’s picture

geerlingguy commented
Status: Active » Needs review
StatusFileSize
new flag_undefined_index-1160738-2.diff585 bytes

Patch attached, gets rid of the error for me. (It's a file patch, didn't have time to do a proper Git patch).

geerlingguy’s picture

geerlingguy commented
Status: Needs review » Needs work

...yeah... that made my views using flag relationships break. D'oh!

sol roth’s picture

sol roth commented

So what's the fix any news?

geerlingguy’s picture

geerlingguy commented

Can't figure anything at this point; I've just been ignoring the error messages :-)

geerlingguy’s picture

geerlingguy commented
Assigned: Unassigned » geerlingguy
Status: Needs work » Needs review
StatusFileSize
new undefined_index-1160738-6.patch2.48 KB

Attached patch fixes the errors (which were getting unbelievably annoying ;-). Basically, I added a check for the variable before the relationship is built. Most of the patch is just indentation level changes.

I don't know if there's any better way around this, but it's working great for me.

TimelessDomain’s picture

TimelessDomain commented

seems to be working for me - thanks

geerlingguy’s picture

geerlingguy commented
Status: Needs review » Reviewed & tested by the community

Marking RTBC, as @TimelessDomain says it works, and it's been working for me for three days now :)

SuperHoman’s picture

SuperHoman commented

is this patch going to be applied to a new release?

thomas.sullivan’s picture

thomas.sullivan commented

Sorry which file is this patch patching?
I'm getting can't find file to patch at input line 5

dddave’s picture

dddave commented

@#9 This module seems to be pretty much abandoned atm. If somebody capable would volunteer to become a co-maintainer...

@#10 As the patch clearly states the file to be patched is /includes/flag.views.inc.

thomas.sullivan’s picture

thomas.sullivan commented

Yep see that now. Thanks and sorry.

santam’s picture

santam commented

Thanks the patch worked for me too.

quicksketch’s picture

quicksketch
he/him
commented
Status: Reviewed & tested by the community » Fixed

Thanks, committed #6.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.