Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Tests from #1017672: D6 to D7 update process permanently deletes comment bodies and other data, and throws fatal SQL errors inexplicably started failing a week or so ago. This issue is for figuring out why and getting them applied.
Attaching just the test hunk here.
Comment | File | Size | Author |
---|---|---|---|
#14 | node-type-disabled-1160928-13.patch | 2.58 KB | xjm |
#14 | interdiff.txt | 857 bytes | xjm |
#12 | node_type_disabled_1160928.patch | 2.57 KB | catch |
#10 | node_type_disabled_1160928.patch | 1.6 KB | catch |
just_tests.patch | 2.74 KB | catch | |
Comments
Comment #1
webchickSubscribing.
Comment #3
Tor Arne Thune CreditAttribution: Tor Arne Thune commentedjust_tests.patch queued for re-testing.
Comment #5
Tor Arne Thune CreditAttribution: Tor Arne Thune commentedHas the file
modules/simpletest/tests/upgrade/upgrade.node.test
been removed?Comment #6
catch@1V - it was removed from Drupal 8, but not Drupal 7.
Comment #8
catchjust_tests.patch queued for re-testing.
Comment #10
catchDoh, what about this then.
Comment #12
catchComment #13
catchSo two issues:
1. The upgrade database had disappeared in one of the many re-rolls on that issue.
2. The test class was doubled up in the file, likely patch applied over itself or something.
So no actual code changes here compared to the patches in #1017672: D6 to D7 update process permanently deletes comment bodies and other data, and throws fatal SQL errors, just fixing the patch itself.
Comment #14
xjmCompulsively sneaking in some doxygen correction with an RTBC.
catch pointed out that this was tested by itself in #1017672-16: D6 to D7 update process permanently deletes comment bodies and other data, and throws fatal SQL errors. (You can see the additional fail over the 29 for the combined patch there, and checking the test results shows the failed assertion: "Comment body field instance was created for comments attached to the disabled forum node type.")
The approach looks reasonable and the test is straightforward and simple.
Comment #15
webchickGreat!
Committed and pushed to 7.x. Thanks!
Comment #16
sun@webchick: You forgot to add the new file.
Comment #17
webchickDuh. One of these days I will remember to do that. :P
Fixed.