$form['#id'] is set rather than $form['#attributes']['id']

affects uc_cart_copy_address js call to copy shipping info to billing

CommentFileSizeAuthor
uc_cart-cart-pane-id-attribute.patch763 bytesemosbaugh

Comments

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Priority: Critical » Normal
Status: Needs review » Postponed (maintainer needs more info)

The fieldset id is set correctly for me without this patch; applying the patch makes no difference to the output of the checkout page.

The copy address checkbox (and other bugs in the checkout address panes) are being dealt with in #1071332: State/Province select boxes need converting to Ajax

emosbaugh’s picture

emosbaugh commented
Status: Postponed (maintainer needs more info) » Closed (cannot reproduce)

ok, i get the correct result as well on a fresh install. ill check whats up with my site when i get a chance.

emosbaugh’s picture

emosbaugh commented

You know what it is. It doesnt work if you subtheme the tao theme. Tao overrides theme_fieldset and tao doesnt call element_set_attributes($element, array('id'));

Maybe this should be a issue in the tao queue.

function theme_fieldset($variables) {
  $element = $variables['element'];
  element_set_attributes($element, array('id'));
emosbaugh’s picture

emosbaugh commented

http://drupal.org/node/1105086#comment-4530516