In edge-case scenarios, #validate and #submit may not be set on a $form.

If another module tries to prepend a form handler in hook_form_alter() using array_unshift() or the like, a PHP warning is thrown.

A potential example for this might be a form that solely uses button-level submit handlers.

CommentFileSizeAuthor
#3 drupal.prepare-form-keys.3.patch932 bytessun
drupal.prepare-form-keys.0.patch959 bytessun

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Could those be located inside the if (!sset()) conditions?

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Could those be located inside the if (!sset()) conditions?

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Issue tags: +Needs backport to D7
StatusFileSize
new drupal.prepare-form-keys.3.patch932 bytes

Very good suggestion.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

#3: drupal.prepare-form-keys.3.patch queued for re-testing.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Needs review » Reviewed & tested by the community

Makes sense.
Although it's not really that hard a bite, I have been bitten by this before.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x and 7.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.