This patch addresses two issues with user updating. 1) The user update resource cannot update a password and 2) Not passing a full user object to drupal_execute when the user_profile_form is built causes problems with modules that implement hook_user('form') - IE block.module.

I will also update the test if/when the patch is accepted.

CommentFileSizeAuthor
#1 user_update-1162648-1.patch1.03 KBdabblela

Comments

dabblela’s picture

dabblela commented
Status: Active » Needs review
StatusFileSize
new user_update-1162648-1.patch1.03 KB
dabblela’s picture

dabblela commented

I'd also propose changing the name of the argument from 'data' to 'account' to match the register/create resource, but I understand at this point that's an API change.

kylebrowning’s picture

kylebrowning commented
Status: Needs review » Reviewed & tested by the community
kylebrowning’s picture

kylebrowning commented
Status: Reviewed & tested by the community » Needs work

Actually, upon initial review it worked fine, but I might not have applied the patch. When i ran the tests before committing this, it failed. Please run the test locally

dabblela’s picture

dabblela commented
Status: Needs work » Needs review

I'm not sure, what fails did you see? I downloaded 6.x-3.x-dev, applied this patch and ran all the Services tests.

kylebrowning’s picture

kylebrowning commented
Status: Needs review » Closed (fixed)

Fix in dev.