Manual testing revealed a glitch in the Mollom backend - submitting a form without any values results in an Internal Server Error.

This cannot be fixed in the Mollom module, but we can start to add some minimalistic, client-side tests to ensure that Mollom's production API (non-testing mode) works like it should.

Attached patch will obviously fail until the backend issue is resolved.

CommentFileSizeAuthor
mollom.post-body-empty.0.patch1.29 KBsun

Comments

Status: Needs review » Needs work

The last submitted patch, mollom.post-body-empty.0.patch, failed testing.

blackskad’s picture

blackskad commented
Status: Needs work » Needs review

mollom.post-body-empty.0.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, mollom.post-body-empty.0.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Further investigation revealed that the "testing keys" being used in the Drupal module tests have the testing mode enabled on the backend, so it cannot be disabled or toggled off from the client.

In turn, this means that this patch cannot be committed and the general idea is not supported.

However, we still want to see this patch to pass tests to confirm that the bug also doesn't exist when testing mode is enabled. A fix will be deployed later today.

Thanks, @blackskad!

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Needs review

mollom.post-body-empty.0.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, mollom.post-body-empty.0.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Closed (won't fix)

Alright, thanks. Looks like an unrelated assertion in mollom.checkLanguage tests failed for whatever reason, but that's not related to this issue. Therefore, closing this issue.